Skip to content

Commit e4773fb

Browse files
committed
compat fixes
1 parent 12d7326 commit e4773fb

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ let package = Package(
88
.library(name: "Tracing", targets: ["Tracing"]),
99
],
1010
dependencies: [
11-
.package(url: "https://github.com/apple/swift-distributed-tracing-baggage.git", .upToNextMinor(from: "0.3.0")),
11+
.package(url: "https://github.com/apple/swift-distributed-tracing-baggage.git", .upToNextMinor(from: "0.4.1")),
1212
.package(url: "https://github.com/apple/swift-docc-plugin", from: "1.0.0"),
1313
],
1414
targets: [

Sources/Tracing/Tracer.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ extension Tracer {
202202
)
203203
defer { span.end() }
204204
do {
205-
return try await Baggage.$current.withValue(span.baggage) {
205+
return try await Baggage.withValue(span.baggage) {
206206
try await operation(span)
207207
}
208208
} catch {
@@ -239,7 +239,7 @@ extension Tracer {
239239
let span = self.startSpan(operationName, baggage: baggage, ofKind: kind, function: function, file: fileID, line: line)
240240
defer { span.end() }
241241
do {
242-
return try await Baggage.$current.withValue(span.baggage) {
242+
return try await Baggage.withValue(span.baggage) {
243243
try await operation(span)
244244
}
245245
} catch {

Tests/TracingTests/DynamicTracepointTracerTests.swift

+6
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ final class DynamicTracepointTracerTests: XCTestCase {
2424
}
2525

2626
func test_adhoc_enableBySourceLoc() {
27+
#if swift(>=5.5)
2728
let tracer = DynamicTracepointTestTracer()
2829

2930
InstrumentationSystem.bootstrapInternal(tracer)
@@ -55,9 +56,11 @@ final class DynamicTracepointTracerTests: XCTestCase {
5556
}
5657
XCTAssertEqual(tracer.spans[0].baggage.spanID, "span-id-fake-\(fileID)-\(fakeLine)")
5758
XCTAssertEqual(tracer.spans[1].baggage.spanID, "span-id-fake-\(fileID)-\(fakeNextLine)")
59+
#endif
5860
}
5961

6062
func test_adhoc_enableByFunction() {
63+
#if swift(>=5.5)
6164
let tracer = DynamicTracepointTestTracer()
6265

6366
InstrumentationSystem.bootstrapInternal(tracer)
@@ -80,6 +83,7 @@ final class DynamicTracepointTracerTests: XCTestCase {
8083
}
8184
XCTAssertEqual(tracer.spans[0].baggage.spanID, "span-id-fake-\(fileID)-\(fakeLine)")
8285
XCTAssertEqual(tracer.spans[1].baggage.spanID, "span-id-fake-\(fileID)-\(fakeNextLine)")
86+
#endif
8387
}
8488

8589
func logic(fakeLine: UInt) {
@@ -88,11 +92,13 @@ final class DynamicTracepointTracerTests: XCTestCase {
8892
}
8993

9094
func traceMeLogic(fakeLine: UInt) {
95+
#if swift(>=5.5)
9196
InstrumentationSystem.tracer.withSpan("\(#function)-yes", line: fakeLine) { _ in
9297
InstrumentationSystem.tracer.withSpan("\(#function)-yes-inside", line: fakeLine + 11) { _ in
9398
// inside
9499
}
95100
}
101+
#endif
96102
}
97103
}
98104

0 commit comments

Comments
 (0)