Skip to content

Rename TracerProtocol if possible #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fitomad opened this issue Mar 30, 2023 · 4 comments
Closed

Rename TracerProtocol if possible #104

fitomad opened this issue Mar 30, 2023 · 4 comments
Milestone

Comments

@fitomad
Copy link

fitomad commented Mar 30, 2023

The Protocol suffix in the TracerProtocol protocol's name is redundant in this case and brings unnecessary information.

Suggestion

Remove the Protocol suffix renaming the protocol to Trackable.

The same case could be applied to the LegacyTracerProtocol protocol.
In that case, the protocol name becomes LegacyTrackable.

@ktoso
Copy link
Member

ktoso commented Mar 30, 2023

Thanks for the feedback but it's a bit more complex than that.

The protocol suffix is a standard pattern when we need the proper name for a namsespace which we do here: enum Tracer

HOWEVER, we just worked out that we can lift functions into free functions and it'll work just as fine so we'll be recovering the protocol Tracer.

I'll close this as a duplicate of: #109

@ktoso ktoso closed this as completed Mar 30, 2023
@ktoso ktoso added this to the 1.0.0 milestone Mar 30, 2023
@ktoso ktoso changed the title Rename TracerProtocol to Trackable Rename TracerProtocol if possible Mar 30, 2023
@ktoso
Copy link
Member

ktoso commented Mar 30, 2023

Duplicate of #109

@ktoso ktoso marked this as a duplicate of #109 Mar 30, 2023
@ktoso
Copy link
Member

ktoso commented Mar 30, 2023

Solved in: #113

@fitomad
Copy link
Author

fitomad commented Mar 30, 2023

Thanks for the feedback but it's a bit more complex than that.

The protocol suffix is a standard pattern when we need the proper name for a namsespace which we do here: enum Tracer

HOWEVER, we just worked out that we can lift functions into free functions and it'll work just as fine so we'll be recovering the protocol Tracer.

I'll close this as a duplicate of: #109

Thanks for the explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants