-
Notifications
You must be signed in to change notification settings - Fork 37
Rename TracerProtocol if possible #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the feedback but it's a bit more complex than that. The protocol suffix is a standard pattern when we need the proper name for a namsespace which we do here: HOWEVER, we just worked out that we can lift functions into free functions and it'll work just as fine so we'll be recovering the I'll close this as a duplicate of: #109 |
Duplicate of #109 |
Solved in: #113 |
Thanks for the explanation |
The
Protocol
suffix in theTracerProtocol
protocol's name is redundant in this case and brings unnecessary information.Suggestion
Remove the
Protocol
suffix renaming the protocol toTrackable
.The same case could be applied to the
LegacyTracerProtocol
protocol.In that case, the protocol name becomes
LegacyTrackable
.The text was updated successfully, but these errors were encountered: