Skip to content

Commit 350794f

Browse files
authored
uncomment visionOS CI tasks (#3176)
### Motivation: These don't work on all versions but we should allow people to opt-in if they know they do work ### Modifications: Uncomment the steps and make the step default to off ### Result: People can choose to run visionOS builds and tests
1 parent 7d3204d commit 350794f

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

.github/workflows/macos_tests.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ on:
101101
default: false
102102
visionos_xcode_build_enabled:
103103
type: boolean
104-
description: "Boolean to enable the Xcode build targeting visionOS. Defaults to true."
105-
default: true
104+
description: "Boolean to enable the Xcode build targeting visionOS. Defaults to false."
105+
default: false
106106
visionos_xcode_test_enabled:
107107
type: boolean
108108
description: "Boolean to enable the Xcode test targeting visionOS. Defaults to false."
@@ -268,12 +268,12 @@ jobs:
268268
- name: tvOS test
269269
if: '!cancelled() && inputs.tvos_xcode_test_enabled'
270270
run: /usr/bin/xcodebuild -quiet -scheme ${BUILD_SCHEME} -destination "name=Apple TV 4K (3rd generation)" test
271-
# - name: visionOS build # arm only # TODO: disabled due to issue
272-
# if: '!cancelled() && inputs.visionos_xcode_build_enabled'
273-
# run: /usr/bin/xcodebuild -quiet -scheme ${BUILD_SCHEME} -destination "generic/platform=visionos" build
274-
# - name: visionOS test # arm only # TODO: disabled due to issue
275-
# if: '!cancelled() && inputs.visionos_xcode_test_enabled'
276-
# run: /usr/bin/xcodebuild -quiet -scheme ${BUILD_SCHEME} -destination "name=Apple Vision Pro" test
271+
- name: visionOS build # arm only
272+
if: '!cancelled() && inputs.visionos_xcode_build_enabled'
273+
run: /usr/bin/xcodebuild -quiet -scheme ${BUILD_SCHEME} -destination "generic/platform=visionos" build
274+
- name: visionOS test # arm only
275+
if: '!cancelled() && inputs.visionos_xcode_test_enabled'
276+
run: /usr/bin/xcodebuild -quiet -scheme ${BUILD_SCHEME} -destination "name=Apple Vision Pro" test
277277
env:
278278
XCODE_VERSION: ${{ matrix.config.xcode_version }}
279279
DEVELOPER_DIR: "/Applications/Xcode_${{ matrix.config.xcode_version }}.app"

0 commit comments

Comments
 (0)