pkgconfig System Module Search Paths #257
Conversation
aciidgh
changed the title
|
LGTM, but conflicts. |
|
Fixed |
|
@swift-ci Please test and merge |
|
We should look at the pkg-config sources, I'm not sure this path is even in the general set. |
| libs = resolveVariables(value(line: line)).chomp() | ||
| } else if line.hasPrefix("Cflags: ") { | ||
| cFlags = resolveVariables( value(line: line)).chomp() | ||
| } |
There was a problem hiding this comment.
I'm not very familiar with the format, but I would recommend trying to get an else clause in here that will error out if we see something unexpected. This prevents the code from silently failing to work properly.
There was a problem hiding this comment.
this is not really an exhaustive list of possible cases in the file, there are some things for eg Name: Description: etc which we aren't interested in and nor want to parse, how to handle those ?
There was a problem hiding this comment.
Is there a complete list available? If so, we could just check if it is in the known complete list and ignore if not there.
We can at least partition into the following three cases, right?
- Variable assignment
- Key-value binding (Name: Value)
- Comment
There was a problem hiding this comment.
Yeah I think those are the only cases. I'll rework the parser in another PR which should address the parser related comments
|
Seems to work very well for |
Report extended results in commandProcessFinished
This aims at implementing : https://github.com/apple/swift-evolution/blob/master/proposals/0063-swiftpm-system-module-search-paths.md
Tested with compiling GTK+3