Skip to content

Commit 00449ee

Browse files
authored
fixed type of AqlExecutionExplainEntity.warnings (#579)
1 parent 3a9b10f commit 00449ee

File tree

3 files changed

+26
-2
lines changed

3 files changed

+26
-2
lines changed

core/src/main/java/com/arangodb/entity/AqlExecutionExplainEntity.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public final class AqlExecutionExplainEntity {
2929

3030
private ExecutionPlan plan;
3131
private Collection<ExecutionPlan> plans;
32-
private Collection<String> warnings;
32+
private Collection<CursorWarning> warnings;
3333
private ExecutionStats stats;
3434
private Boolean cacheable;
3535

@@ -41,7 +41,7 @@ public Collection<ExecutionPlan> getPlans() {
4141
return plans;
4242
}
4343

44-
public Collection<String> getWarnings() {
44+
public Collection<CursorWarning> getWarnings() {
4545
return warnings;
4646
}
4747

test-functional/src/test/java/com/arangodb/ArangoDatabaseAsyncTest.java

+12
Original file line numberDiff line numberDiff line change
@@ -1084,6 +1084,18 @@ void explainQueryWithBindVars(ArangoDatabaseAsync db) throws ExecutionException,
10841084
assertThat(plan.getNodes()).isNotEmpty();
10851085
}
10861086

1087+
@ParameterizedTest
1088+
@MethodSource("asyncDbs")
1089+
void explainQueryWithWarnings(ArangoDatabaseAsync db) throws ExecutionException, InterruptedException {
1090+
AqlExecutionExplainEntity explain = db.explainQuery("return 1/0", null, null).get();
1091+
assertThat(explain.getWarnings())
1092+
.hasSize(1)
1093+
.allSatisfy(w -> {
1094+
assertThat(w.getCode()).isEqualTo(1562);
1095+
assertThat(w.getMessage()).isEqualTo("division by zero");
1096+
});
1097+
}
1098+
10871099
@ParameterizedTest
10881100
@MethodSource("asyncDbs")
10891101
void explainQueryWithIndexNode(ArangoDatabaseAsync db) throws ExecutionException, InterruptedException {

test-functional/src/test/java/com/arangodb/ArangoDatabaseTest.java

+12
Original file line numberDiff line numberDiff line change
@@ -1157,6 +1157,18 @@ void explainQueryWithBindVars(ArangoDatabase db) {
11571157
assertThat(plan.getNodes()).isNotEmpty();
11581158
}
11591159

1160+
@ParameterizedTest
1161+
@MethodSource("dbs")
1162+
void explainQueryWithWarnings(ArangoDatabase db) {
1163+
AqlExecutionExplainEntity explain = db.explainQuery("return 1/0", null, null);
1164+
assertThat(explain.getWarnings())
1165+
.hasSize(1)
1166+
.allSatisfy(w -> {
1167+
assertThat(w.getCode()).isEqualTo(1562);
1168+
assertThat(w.getMessage()).isEqualTo("division by zero");
1169+
});
1170+
}
1171+
11601172
@ParameterizedTest
11611173
@MethodSource("dbs")
11621174
void explainQueryWithIndexNode(ArangoDatabase db) {

0 commit comments

Comments
 (0)