Skip to content

Commit 7a5c01f

Browse files
committed
[DE-233] deprecated usage of VPack serializer
1 parent 150f092 commit 7a5c01f

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

src/main/java/com/arangodb/ArangoDB.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@
5858
import com.arangodb.velocystream.Request;
5959
import com.arangodb.velocystream.Response;
6060
import org.apache.http.client.HttpRequestRetryHandler;
61+
import org.slf4j.Logger;
62+
import org.slf4j.LoggerFactory;
6163

6264
import javax.net.ssl.HostnameVerifier;
6365
import javax.net.ssl.SSLContext;
@@ -91,7 +93,7 @@ public interface ArangoDB extends ArangoSerializationAccessor {
9193
* @author Mark Vollmary
9294
*/
9395
class Builder extends InternalArangoDBBuilder {
94-
96+
private static final Logger logger = LoggerFactory.getLogger(Builder.class);
9597
private static final String PROPERTY_KEY_PROTOCOL = "arangodb.protocol";
9698

9799
protected Protocol protocol;
@@ -672,6 +674,11 @@ public Builder serializer(final ArangoSerialization serialization) {
672674
* @return {@link ArangoDB}
673675
*/
674676
public synchronized ArangoDB build() {
677+
if (customSerializer == null) {
678+
logger.warn("Usage of VelocyPack Java serialization is now deprecated for removal. " +
679+
"Future driver versions will only support Jackson serialization (for both JSON and VPACK formats). " +
680+
"Please configure according to: https://www.arangodb.com/docs/stable/drivers/java-reference-serialization.html");
681+
}
675682
if (hosts.isEmpty()) {
676683
hosts.add(host);
677684
}

src/main/java/com/arangodb/async/ArangoDBAsync.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@
4747
import com.arangodb.velocypack.*;
4848
import com.arangodb.velocystream.Request;
4949
import com.arangodb.velocystream.Response;
50+
import org.slf4j.Logger;
51+
import org.slf4j.LoggerFactory;
5052

5153
import javax.net.ssl.SSLContext;
5254
import java.io.InputStream;
@@ -343,6 +345,8 @@ default CompletableFuture<Boolean> createDatabase(final String name) {
343345
@SuppressWarnings("unused")
344346
class Builder extends InternalArangoDBBuilder {
345347

348+
private static final Logger logger = LoggerFactory.getLogger(Builder.class);
349+
346350
public Builder() {
347351
super();
348352
}
@@ -858,6 +862,11 @@ public Builder serializer(final ArangoSerialization serialization) {
858862
* @return {@link ArangoDBAsync}
859863
*/
860864
public synchronized ArangoDBAsync build() {
865+
if (customSerializer == null) {
866+
logger.warn("Usage of VelocyPack Java serialization is now deprecated for removal. " +
867+
"Future driver versions will only support Jackson serialization (for both JSON and VPACK formats). " +
868+
"Please configure according to: https://www.arangodb.com/docs/stable/drivers/java-reference-serialization.html");
869+
}
861870
if (hosts.isEmpty()) {
862871
hosts.add(host);
863872
}

0 commit comments

Comments
 (0)