issue #269: Undefined index: revision

jsteemann · jsteemann · commit 827e99d4ac00 · 2021-06-09T10:43:31.000+02:00
Fix an undefined index notice/warning when calling the
DocumentHandler::put function with a `revision` option set.
diff --git a/lib/ArangoDBClient/DocumentHandler.php b/lib/ArangoDBClient/DocumentHandler.php
@@ -757,9 +757,10 @@ protected function put($url, $collection, $documentId, Document $document, array
         if (isset($params[ConnectionOptions::OPTION_REPLACE_POLICY]) &&
             $params[ConnectionOptions::OPTION_REPLACE_POLICY] === UpdatePolicy::ERROR
         ) {
-            if (null !== $options['revision']) {
+            $revision = $document->getRevision();
+            if (null !== $revision) {
                 $params['ignoreRevs'] = false;
-                $headers['if-match']  = '"' . $options['revision'] . '"';
+                $headers['if-match']  = '"' . $revision . '"';
             }
         }
         

Original file line number	Diff line number	Diff line change
`@@ -757,9 +757,10 @@ protected function put($url, $collection, $documentId, Document $document, array`
`757`	`757`	`if (isset($params[ConnectionOptions::OPTION_REPLACE_POLICY]) &&`
`758`	`758`	`$params[ConnectionOptions::OPTION_REPLACE_POLICY] === UpdatePolicy::ERROR`
`759`	`759`	`) {`
`760`		`- if (null !== $options['revision']) {`
	`760`	`+ $revision = $document->getRevision();`
	`761`	`+ if (null !== $revision) {`
`761`	`762`	`$params['ignoreRevs'] = false;`
`762`		`- $headers['if-match'] = '"' . $options['revision'] . '"';`
	`763`	`+ $headers['if-match'] = '"' . $revision . '"';`
`763`	`764`	`}`
`764`	`765`	`}`
`765`	`766`