Skip to content

Commit b07db7e

Browse files
committed
fix the issues with namespaces for cluster scope
1 parent 17553b1 commit b07db7e

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

Diff for: cmd/main.go

+7-3
Original file line numberDiff line numberDiff line change
@@ -407,20 +407,24 @@ func newOperatorConfigAndDeps(id, namespace, name string) (operator.Config, oper
407407
return operator.Config{}, operator.Dependencies{}, errors.WithStack(fmt.Errorf("Failed to get my pod's service account: %s", err))
408408
}
409409

410-
eventRecorder := createRecorder(cliLog, client.Kubernetes(), name, namespace)
411-
412410
scope, ok := scope.AsScope(operatorOptions.scope)
413411
if !ok {
414412
return operator.Config{}, operator.Dependencies{}, errors.WithStack(fmt.Errorf("Scope %s is not known by Operator", operatorOptions.scope))
415413
}
416414

415+
var watchNamespace string
417416
if scope.IsCluster() {
418-
namespace = metav1.NamespaceAll
417+
watchNamespace = metav1.NamespaceAll
418+
} else {
419+
watchNamespace = namespace
419420
}
420421

422+
eventRecorder := createRecorder(cliLog, client.Kubernetes(), name, watchNamespace)
423+
421424
cfg := operator.Config{
422425
ID: id,
423426
Namespace: namespace,
427+
WatchNamespace: watchNamespace,
424428
PodName: name,
425429
ServiceAccount: serviceAccount,
426430
OperatorImage: image,

Diff for: pkg/operator/operator.go

+1
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ type Operator struct {
9292
type Config struct {
9393
ID string
9494
Namespace string
95+
WatchNamespace string
9596
PodName string
9697
ServiceAccount string
9798
OperatorImage string

Diff for: pkg/operator/operator_deployment.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func (o *Operator) runDeployments(stop <-chan struct{}) {
4949
o.log,
5050
o.Client.Arango().DatabaseV1().RESTClient(),
5151
deploymentType.ArangoDeploymentResourcePlural,
52-
o.Config.Namespace,
52+
o.Config.WatchNamespace,
5353
&api.ArangoDeployment{},
5454
cache.ResourceEventHandlerFuncs{
5555
AddFunc: o.onAddArangoDeployment,

Diff for: pkg/operator/operator_deployment_relication.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func (o *Operator) runDeploymentReplications(stop <-chan struct{}) {
4949
o.log,
5050
o.Dependencies.Client.Arango().ReplicationV1().RESTClient(),
5151
replication2.ArangoDeploymentReplicationResourcePlural,
52-
o.Config.Namespace,
52+
o.Config.WatchNamespace,
5353
&api.ArangoDeploymentReplication{},
5454
cache.ResourceEventHandlerFuncs{
5555
AddFunc: o.onAddArangoDeploymentReplication,
@@ -201,7 +201,7 @@ func (o *Operator) handleDeploymentReplicationEvent(event *Event) error {
201201
// makeDeploymentReplicationConfigAndDeps creates a Config & Dependencies object for a new DeploymentReplication.
202202
func (o *Operator) makeDeploymentReplicationConfigAndDeps(apiObject *api.ArangoDeploymentReplication) (replication.Config, replication.Dependencies) {
203203
cfg := replication.Config{
204-
Namespace: o.Config.Namespace,
204+
Namespace: o.Config.WatchNamespace,
205205
}
206206
deps := replication.Dependencies{
207207
Log: o.Dependencies.LogService.MustGetLogger(logging.LoggerNameDeploymentReplication).With().

0 commit comments

Comments
 (0)