Move OTA functions in newly added OTA.cpp file

Author: pennam

src/ArduinoIoTCloudTCP.cpp

@@ -138,7 +138,7 @@ int ArduinoIoTCloudTCP::begin(bool const enable_watchdog, String brokerAddress,
 #endif /* AVR */
 
 #if OTA_ENABLED && !defined(__AVR__)
-  _ota_img_sha256 = getOTAImageSHA256();
+  _ota_img_sha256 = OTA::getImageSHA256();
   DEBUG_VERBOSE("SHA256: HASH(%d) = %s", strlen(_ota_img_sha256.c_str()), _ota_img_sha256.c_str());
 #endif /* OTA_ENABLED */
 
@@ -239,6 +239,10 @@ int ArduinoIoTCloudTCP::begin(bool const enable_watchdog, String brokerAddress,
   _ota_cap = true;
 #endif
 
+#if OTA_ENABLED
+  OTA::setNetworkAdapter(_connection->getInterface());
+#endif
+
 #ifdef BOARD_HAS_OFFLOADED_ECCX08
   if (String(WiFi.firmwareVersion()) < String("1.4.4")) {
     DEBUG_ERROR("ArduinoIoTCloudTCP::%s In order to connect to Arduino IoT Cloud, NINA firmware needs to be >= 1.4.4, current %s", __FUNCTION__, WiFi.firmwareVersion());
@@ -609,7 +613,7 @@ ArduinoIoTCloudTCP::State ArduinoIoTCloudTCP::handle_Connected()
         /* Transmit the cleared request flags to the cloud. */
         sendDevicePropertyToCloud("OTA_REQ");
         /* Call member function to handle OTA request. */
-        onOTARequest();
+        _ota_error = OTA::onRequest(_ota_url);
         /* If something fails send the OTA error to the cloud */
         sendDevicePropertyToCloud("OTA_ERROR");
       }
@@ -762,45 +766,6 @@ int ArduinoIoTCloudTCP::write(String const topic, byte const data[], int const l
   return 0;
 }
 
-#if OTA_ENABLED
-void ArduinoIoTCloudTCP::onOTARequest()
-{
-  DEBUG_INFO("ArduinoIoTCloudTCP::%s _ota_url = %s", __FUNCTION__, _ota_url.c_str());
-
-#ifdef ARDUINO_ARCH_SAMD
-  _ota_error = samd_onOTARequest(_ota_url.c_str());
-#endif
-
-#ifdef ARDUINO_NANO_RP2040_CONNECT
-  _ota_error = rp2040_connect_onOTARequest(_ota_url.c_str());
-#endif
-
-#ifdef BOARD_STM32H7
-  bool const use_ethernet = _connection->getInterface() == NetworkAdapter::ETHERNET ? true : false;
-  _ota_error = portenta_h7_onOTARequest(_ota_url.c_str(), use_ethernet);
-#endif
-
-#ifdef ARDUINO_ARCH_ESP32
-  _ota_error = esp32_onOTARequest(_ota_url.c_str());
-#endif
-}
-
-String ArduinoIoTCloudTCP::getOTAImageSHA256()
-{
-#if defined (ARDUINO_ARCH_SAMD)
-  return samd_getOTAImageSHA256();
-#elif defined (ARDUINO_NANO_RP2040_CONNECT)
-  return rp2040_connect_getOTAImageSHA256();
-#elif defined (BOARD_STM32H7)
-  return portenta_h7_getOTAImageSHA256();
-#elif defined (ARDUINO_ARCH_ESP32)
-  return esp32_getOTAImageSHA256();
-#else
-  # error "No method for SHA256 checksum calculation over application image defined for this architecture."
-#endif
-}
-#endif
-
 void ArduinoIoTCloudTCP::updateThingTopics()
 {
   _shadowTopicOut = getTopic_shadowout();

src/ArduinoIoTCloudTCP.h

@@ -201,8 +201,6 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass
     int write(String const topic, byte const data[], int const length);
 
 #if OTA_ENABLED
-    void onOTARequest();
-    String getOTAImageSHA256();
     void sendDevicePropertyToCloud(String const name);
 #endif
 

src/utility/ota/OTA-portenta-h7.cpp

@@ -35,6 +35,12 @@
 
 #include "../watchdog/Watchdog.h"
 
+/******************************************************************************
+ * LOCAL VARIABLES
+ ******************************************************************************/
+
+static NetworkAdapter _ota_adapter = NetworkAdapter::WIFI;
+
 /******************************************************************************
  * EXTERN
  ******************************************************************************/
@@ -45,7 +51,7 @@ extern RTC_HandleTypeDef RTCHandle;
  * FUNCTION DEFINITION
  ******************************************************************************/
 
-int portenta_h7_onOTARequest(char const * ota_url, const bool use_ethernet)
+int portenta_h7_onOTARequest(char const * ota_url)
 {
   watchdog_reset();
 
@@ -76,7 +82,7 @@ int portenta_h7_onOTARequest(char const * ota_url, const bool use_ethernet)
   /* Download the OTA file from the web storage location. */
   MbedSocketClass * download_socket = static_cast<MbedSocketClass*>(&WiFi);
 #if defined (BOARD_HAS_ETHERNET)
-  if(use_ethernet) {
+  if(_ota_adapter == NetworkAdapter::ETHERNET) {
     download_socket = static_cast<MbedSocketClass*>(&Ethernet);
   }
 #endif
@@ -143,4 +149,9 @@ String portenta_h7_getOTAImageSHA256()
   return sha256_str;
 }
 
+void portenta_h7_setNetworkAdapter(NetworkAdapter iface)
+{
+  _ota_adapter = iface;
+}
+
 #endif /* BOARD_STM32H7 */

src/utility/ota/OTA.cpp

@@ -0,0 +1,108 @@
+/*
+   This file is part of ArduinoIoTCloud.
+
+   Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
+
+   This software is released under the GNU General Public License version 3,
+   which covers the main part of arduino-cli.
+   The terms of this license can be found at:
+   https://www.gnu.org/licenses/gpl-3.0.en.html
+
+   You can be released from the requirements of the above licenses by purchasing
+   a commercial license. Buying such a license is mandatory if you want to modify or
+   otherwise use the software for commercial activities involving the Arduino
+   software without disclosing the source code of your own applications. To purchase
+   a commercial license, send an email to [email protected].
+*/
+
+/******************************************************************************
+ * INCLUDE
+ ******************************************************************************/
+
+#include <AIoTC_Config.h>
+
+#if OTA_ENABLED
+
+#include "OTA.h"
+#include <Arduino_DebugUtils.h>
+
+/******************************************************************************
+ * FUNCTION DEFINITION
+ ******************************************************************************/
+
+#ifdef ARDUINO_ARCH_SAMD
+int samd_onOTARequest(char const * url);
+String samd_getOTAImageSHA256();
+#endif
+
+#ifdef ARDUINO_NANO_RP2040_CONNECT
+int rp2040_connect_onOTARequest(char const * url);
+String rp2040_connect_getOTAImageSHA256();
+#endif
+
+#ifdef BOARD_STM32H7
+int portenta_h7_onOTARequest(char const * url);
+String portenta_h7_getOTAImageSHA256();
+void portenta_h7_setNetworkAdapter(NetworkAdapter iface);
+#endif
+
+#ifdef ARDUINO_ARCH_ESP32
+int esp32_onOTARequest(char const * url);
+String esp32_getOTAImageSHA256();
+#endif
+
+/******************************************************************************
+ * PUBLIC MEMBER FUNCTIONS
+ ******************************************************************************/
+
+
+int OTA::onRequest(String url)
+{
+  DEBUG_INFO("ArduinoIoTCloudTCP::%s _ota_url = %s", __FUNCTION__, url.c_str());
+
+#if defined (ARDUINO_ARCH_SAMD)
+  return samd_onOTARequest(url.c_str());
+#elif defined (ARDUINO_NANO_RP2040_CONNECT)
+  return rp2040_connect_onOTARequest(url.c_str());
+#elif defined (BOARD_STM32H7)
+  return portenta_h7_onOTARequest(url.c_str());
+#elif defined (ARDUINO_ARCH_ESP32)
+  return esp32_onOTARequest(url.c_str());
+#else
+  #error "OTA not supported for this architecture"
+#endif
+}
+
+String OTA::getImageSHA256()
+{
+#if defined (ARDUINO_ARCH_SAMD)
+  return samd_getOTAImageSHA256();
+#elif defined (ARDUINO_NANO_RP2040_CONNECT)
+  return rp2040_connect_getOTAImageSHA256();
+#elif defined (BOARD_STM32H7)
+  return portenta_h7_getOTAImageSHA256();
+#elif defined (ARDUINO_ARCH_ESP32)
+  return esp32_getOTAImageSHA256();
+#else
+  #error "No method for SHA256 checksum calculation over application image defined for this architecture."
+#endif
+}
+
+
+void OTA::setNetworkAdapter(NetworkAdapter iface)
+{
+#if defined (ARDUINO_ARCH_SAMD)
+  /* Only WiFi available */
+#elif defined (ARDUINO_NANO_RP2040_CONNECT)
+  /* Only WiFi available */
+#elif defined (BOARD_STM32H7)
+  portenta_h7_setNetworkAdapter(iface);
+#elif defined (ARDUINO_ARCH_ESP32)
+  /* Only WiFi available */
+#else
+  #error "OTA not supported for this architecture"
+#endif
+}
+
+#endif /* OTA_ENABLED */
+

src/utility/ota/OTA.h

@@ -23,7 +23,10 @@
  ******************************************************************************/
 
 #include <AIoTC_Config.h>
+
+#if OTA_ENABLED
 #include <Arduino.h>
+#include <Arduino_ConnectionHandler.h>
 
 /******************************************************************************
  * DEFINES
@@ -52,27 +55,19 @@ enum class OTAError : int
 };
 
 /******************************************************************************
- * FUNCTION DEFINITION
+ * CLASS DECLARATION
  ******************************************************************************/
 
-#ifdef ARDUINO_ARCH_SAMD
-int samd_onOTARequest(char const * ota_url);
-String samd_getOTAImageSHA256();
-#endif
-
-#ifdef ARDUINO_NANO_RP2040_CONNECT
-int rp2040_connect_onOTARequest(char const * ota_url);
-String rp2040_connect_getOTAImageSHA256();
-#endif
-
-#ifdef BOARD_STM32H7
-int portenta_h7_onOTARequest(char const * ota_url, const bool use_ethernet);
-String portenta_h7_getOTAImageSHA256();
-#endif
-
-#ifdef ARDUINO_ARCH_ESP32
-int esp32_onOTARequest(char const * ota_url);
-String esp32_getOTAImageSHA256();
-#endif
+class OTA
+{
+public:
+
+  static int onRequest(String url);
+  static String getImageSHA256();
+  static void setNetworkAdapter(NetworkAdapter iface);
+
+};
+
+#endif /* OTA_ENABLED */
 
 #endif /* ARDUINO_OTA_LOGIC_H_ */