Handle NaN values in CloudFloat comparison

sebromero · sebromero · commit c383fd7641a1 · 2025-04-07T17:38:55.000+02:00
diff --git a/src/property/types/CloudFloat.h b/src/property/types/CloudFloat.h
@@ -46,7 +46,10 @@ class CloudFloat : public Property {
       return _value;
     }
     virtual bool isDifferentFromCloud() {
-      return _value != _cloud_value && (abs(_value - _cloud_value) >= Property::_min_delta_property);
+      if (std::isnan(_value) || std::isnan(_cloud_value)) {
+        return std::isnan(_value) != std::isnan(_cloud_value);
+      }
+      return _value != _cloud_value && fabs(_value - _cloud_value) >= Property::_min_delta_property;
     }
     virtual void fromCloudToLocal() {
       _value = _cloud_value;

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,10 @@ class CloudFloat : public Property {`
`46`	`46`	`return _value;`
`47`	`47`	`}`
`48`	`48`	`virtual bool isDifferentFromCloud() {`
`49`		`- return _value != _cloud_value && (abs(_value - _cloud_value) >= Property::_min_delta_property);`
	`49`	`+ if (std::isnan(_value) \|\| std::isnan(_cloud_value)) {`
	`50`	`+ return std::isnan(_value) != std::isnan(_cloud_value);`
	`51`	`+ }`
	`52`	`+ return _value != _cloud_value && fabs(_value - _cloud_value) >= Property::_min_delta_property;`
`50`	`53`	`}`
`51`	`54`	`virtual void fromCloudToLocal() {`
`52`	`55`	`_value = _cloud_value;`