Merge pull request #28 from arduino-libraries/begin_stop_fix

iabdalkader · web-flow · commit 972a386c3084 · 2023-03-07T18:05:41.000+02:00
Ensure that begin() is not called multiple times.
diff --git a/src/AdvancedADC.cpp b/src/AdvancedADC.cpp
@@ -117,7 +117,7 @@ int AdvancedADC::begin(uint32_t resolution, uint32_t sample_rate, size_t n_sampl
     ADCName instance = ADC_NP;
 
     // Sanity checks.
-    if (resolution >= AN_ARRAY_SIZE(ADC_RES_LUT)) {
+    if (resolution >= AN_ARRAY_SIZE(ADC_RES_LUT) || (descr && descr->pool)) {
         return 0;
     }
 
diff --git a/src/AdvancedDAC.cpp b/src/AdvancedDAC.cpp
@@ -135,7 +135,7 @@ void AdvancedDAC::write(DMABuffer<Sample> &dmabuf) {
 
 int AdvancedDAC::begin(uint32_t resolution, uint32_t frequency, size_t n_samples, size_t n_buffers) {
     // Sanity checks.
-    if (resolution >= AN_ARRAY_SIZE(DAC_RES_LUT)) {
+    if (resolution >= AN_ARRAY_SIZE(DAC_RES_LUT) || (descr && descr->pool)) {
         return 0;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ int AdvancedADC::begin(uint32_t resolution, uint32_t sample_rate, size_t n_sampl`
`117`	`117`	`ADCName instance = ADC_NP;`
`118`	`118`
`119`	`119`	`// Sanity checks.`
`120`		`- if (resolution >= AN_ARRAY_SIZE(ADC_RES_LUT)) {`
	`120`	`+ if (resolution >= AN_ARRAY_SIZE(ADC_RES_LUT) \|\| (descr && descr->pool)) {`
`121`	`121`	`return 0;`
`122`	`122`	`}`
`123`	`123`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ void AdvancedDAC::write(DMABuffer<Sample> &dmabuf) {`
`135`	`135`
`136`	`136`	`int AdvancedDAC::begin(uint32_t resolution, uint32_t frequency, size_t n_samples, size_t n_buffers) {`
`137`	`137`	`// Sanity checks.`
`138`		`- if (resolution >= AN_ARRAY_SIZE(DAC_RES_LUT)) {`
	`138`	`+ if (resolution >= AN_ARRAY_SIZE(DAC_RES_LUT) \|\| (descr && descr->pool)) {`
`139`	`139`	`return 0;`
`140`	`140`	`}`
`141`	`141`