Skip to content

Commit 350efc4

Browse files
authored
Bugfix: 'Serial.begin()' now needs to be called within every thread that wants to use it. (#41)
1 parent e06adb3 commit 350efc4

File tree

9 files changed

+28
-20
lines changed

9 files changed

+28
-20
lines changed

Diff for: examples/Threading/Demo_Shared_Counter/Consumer.inot

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
1-
void setup() {
2-
1+
void setup()
2+
{
3+
Serial.begin(9600);
4+
while(!Serial) { }
35
}
46

5-
void loop() {
7+
void loop()
8+
{
69
Serial.println(counter);
710
}

Diff for: examples/Threading/Demo_Shared_Counter/Demo_Shared_Counter.ino

-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
void setup()
22
{
3-
Serial.begin(115200);
4-
while (!Serial) { }
5-
63
Producer.start();
74
Consumer.start();
85
}

Diff for: examples/Threading/Demo_Shared_Counter/Producer.inot

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
void setup() {
1+
void setup()
2+
{
23

34
}
45

5-
void loop() {
6+
void loop()
7+
{
68
static int i = 0;
79
counter = i;
810
i++;

Diff for: examples/Threading/Demo_Source_Sink_Counter/Consumer.inot

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ SINK(counter, int, 10);
22

33
void setup()
44
{
5-
5+
Serial.begin(9600);
6+
while(!Serial) { }
67
}
78

89
void loop()

Diff for: examples/Threading/Demo_Source_Sink_LED/Demo_Source_Sink_LED.ino

+4-2
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,14 @@
44
* together using the "connectTo" method.
55
*/
66

7-
void setup() {
7+
void setup()
8+
{
89
Source_Thread.led.connectTo(Sink_Thread.led);
910
Sink_Thread.start();
1011
Source_Thread.start();
1112
}
1213

13-
void loop() {
14+
void loop()
15+
{
1416
rtos::ThisThread::yield();
1517
}

Diff for: examples/Threadsafe_IO/Threadsafe_SPI/Threadsafe_SPI.ino

+3
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ byte bmp388_read_reg(byte const reg_addr)
7575

7676
void bmp388_thread_func()
7777
{
78+
Serial.begin(9600);
79+
while(!Serial) { }
80+
7881
for(;;)
7982
{
8083
/* Sleep between 5 and 500 ms */

Diff for: examples/Threadsafe_IO/Threadsafe_SPI_BusIO/Threadsafe_SPI_BusIO.ino

+3-3
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ static char thread_name[NUM_THREADS][32];
3535

3636
void setup()
3737
{
38-
Serial.begin(9600);
39-
while (!Serial) { }
40-
4138
pinMode(BMP388_CS_PIN, OUTPUT);
4239
digitalWrite(BMP388_CS_PIN, HIGH);
4340

@@ -70,6 +67,9 @@ byte bmp388_read_reg(byte const reg_addr)
7067

7168
void bmp388_thread_func()
7269
{
70+
Serial.begin(9600);
71+
while(!Serial) { }
72+
7373
for(;;)
7474
{
7575
/* Sleep between 5 and 500 ms */

Diff for: examples/Threadsafe_IO/Threadsafe_Wire/Threadsafe_Wire.ino

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ static char thread_name[NUM_THREADS][32];
3434

3535
void setup()
3636
{
37-
Serial.begin(9600);
38-
while (!Serial) { }
39-
4037
/* Fire up some threads all accessing the LSM6DSOX */
4138
for(size_t i = 0; i < NUM_THREADS; i++)
4239
{
@@ -76,6 +73,9 @@ byte lsm6dsox_read_reg(byte const reg_addr)
7673

7774
void lsm6dsox_thread_func()
7875
{
76+
Serial.begin(9600);
77+
while(!Serial) { }
78+
7979
for(;;)
8080
{
8181
/* Sleep between 5 and 500 ms */

Diff for: examples/Threadsafe_IO/Threadsafe_Wire_BusIO/Threadsafe_Wire_BusIO.ino

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ static char thread_name[NUM_THREADS][32];
3434

3535
void setup()
3636
{
37-
Serial.begin(9600);
38-
while (!Serial) { }
39-
4037
/* Fire up some threads all accessing the LSM6DSOX */
4138
for(size_t i = 0; i < NUM_THREADS; i++)
4239
{
@@ -64,6 +61,9 @@ byte lsm6dsox_read_reg(byte reg_addr)
6461

6562
void lsm6dsox_thread_func()
6663
{
64+
Serial.begin(9600);
65+
while(!Serial) { }
66+
6767
for(;;)
6868
{
6969
/* Sleep between 5 and 500 ms */

0 commit comments

Comments
 (0)