fix of bounds memset

technyon · technyon · commit 39be07e4e692 · 2023-01-31T17:25:46.000+01:00
diff --git a/src/Dhcp.cpp b/src/Dhcp.cpp
@@ -26,9 +26,12 @@ int DhcpClass::beginWithDHCP(uint8_t *mac, unsigned long timeout, unsigned long
 void DhcpClass::reset_DHCP_lease()
 {
 	// zero out _dhcpSubnetMask, _dhcpGatewayIp, _dhcpLocalIp, _dhcpDhcpServerIp, _dhcpDnsServerIp
-	memset(_dhcpLocalIp, 0, 20);
+	memset(_dhcpLocalIp, 0, sizeof(_dhcpLocalIp));
+    memset(_dhcpSubnetMask, 0, sizeof(_dhcpSubnetMask));
+    memset(_dhcpGatewayIp, 0, sizeof(_dhcpGatewayIp));
+    memset(_dhcpDhcpServerIp, 0, sizeof(_dhcpDhcpServerIp));
+    memset(_dhcpDnsServerIp, 0, sizeof(_dhcpDnsServerIp));
 }
-
 	//return:0 on error, 1 if request is sent and response is received
 int DhcpClass::request_DHCP_lease()
 {

Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,12 @@ int DhcpClass::beginWithDHCP(uint8_t *mac, unsigned long timeout, unsigned long`
`26`	`26`	`void DhcpClass::reset_DHCP_lease()`
`27`	`27`	`{`
`28`	`28`	`// zero out _dhcpSubnetMask, _dhcpGatewayIp, _dhcpLocalIp, _dhcpDhcpServerIp, _dhcpDnsServerIp`
`29`		`- memset(_dhcpLocalIp, 0, 20);`
	`29`	`+ memset(_dhcpLocalIp, 0, sizeof(_dhcpLocalIp));`
	`30`	`+ memset(_dhcpSubnetMask, 0, sizeof(_dhcpSubnetMask));`
	`31`	`+ memset(_dhcpGatewayIp, 0, sizeof(_dhcpGatewayIp));`
	`32`	`+ memset(_dhcpDhcpServerIp, 0, sizeof(_dhcpDhcpServerIp));`
	`33`	`+ memset(_dhcpDnsServerIp, 0, sizeof(_dhcpDnsServerIp));`
`30`	`34`	`}`
`31`		`-`
`32`	`35`	`//return:0 on error, 1 if request is sent and response is received`
`33`	`36`	`int DhcpClass::request_DHCP_lease()`
`34`	`37`	`{`