Skip to content

Is there a reason why the 3.2.0 isn't available in PlatformIO? #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FredM67 opened this issue Sep 19, 2021 · 11 comments
Closed

Is there a reason why the 3.2.0 isn't available in PlatformIO? #152

FredM67 opened this issue Sep 19, 2021 · 11 comments
Assignees
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Comments

@FredM67
Copy link

FredM67 commented Sep 19, 2021

In PlatformIO, I get only the 3.1.0 :-(

@per1234
Copy link
Contributor

per1234 commented Sep 19, 2021

Closing as duplicate of #78

Since history showed that maintaining duplicate metadata files is not feasible and PlatformIO has support for Arduino's library.properties metadata file, the superfluous library.json metadata file was removed from this repository (#121). Please request the PlatformIO library registry maintainers to update the NTPClient library registration to point to this metadata file: https://github.com/arduino-libraries/NTPClient/blob/master/library.properties

@ivankravets
Copy link
Contributor

@per1234 could we ask you to bump v3.2.1? The v3.2.0 tag is broken, there are multiple manifests with different "version" fields. See https://github.com/arduino-libraries/NTPClient/tree/3.2.0

arduino-libraries/NTPClient in PlatformIO Registry still points to the 3.1.0.

@per1234
Copy link
Contributor

per1234 commented Apr 9, 2022

Hi @ivankravets. I'm not really in the role to make releases of this project, but I will reopen the issue since it seems it is distinct from #78 after all. That will allow us to more effectively track the issue.

@per1234 per1234 reopened this Apr 9, 2022
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure and removed conclusion: duplicate Has already been submitted labels Apr 9, 2022
@ivankravets
Copy link
Contributor

Thanks, @per1234

The same issue with https://github.com/arduino-libraries/ArduinoHttpClient , the library.json manifest does not contain "version" field.

I agree with you, it makes sense to remove "library.json" files from the libraries from this org if you don't need advanced control over the library build process.

Who could help with this?

@per1234
Copy link
Contributor

per1234 commented Apr 9, 2022

The same issue with https://github.com/arduino-libraries/ArduinoHttpClient , the library.json manifest does not contain "version" field.

Thanks for bringing that to our attention. I have submitted a PR to address the issue: arduino-libraries/ArduinoHttpClient#133

Who could help with this?

I have assigned the issue to @aentinger since I see they have been the most actively involved with the project recently.

@aentinger
Copy link
Contributor

I'm a bit confused here.

It sounds to me the best way forward would be to drop this line and then make a new release, i.e. v3.2.1? Please note that we do not control what platform.io does or does not do 🤷 .

@per1234
Copy link
Contributor

per1234 commented Apr 25, 2022

@aentinger the problem was caused by this line:

https://github.com/arduino-libraries/NTPClient/blob/3.2.0/library.json#L21

  "version": "3.1.0",

It was not updated before the creation of the 3.2.0 tag in this repository, which caused the 3.2.0 tag to be rejected by the PlatformIO library manager. So PlatformIO users only have access to the old version from the time of the 3.1.0 tag.

The problem has since been fixed by the removal of the improperly maintained library.json file in #121

But there has not been a tag since that fix was made, so the fix hasn't actually taken effect yet. That will only happen when a new release of the library is made:

  1. Bump the version field in library.properties
  2. Make a new tag or release.

Please note that we do not control what platform.io does or does not do

PlatformIO supports the library.properties metadata file. So the only thing that needs to be done is for us to maintain the file as is required by the Arduino Library Manager and PlatformIO will be able to work with that no problem. The previous problem was caused by the presence of PlatformIO's preferred library.json file in the repository. If that file is present, then it is used, and so must be valid. A problem with the library.json will cause the library to be rejected by the PlatformIO library manager even if the library.properties file is perfect. But we don't need to worry about that at all now that the library.json file has been removed.

@aentinger
Copy link
Contributor

Thank you for the explanation 👍 The thing that got me confused was that I could not find the library.json file anymore, which from the messages I learned was the apparent offender. Will follow your suggestions 👍

@aentinger
Copy link
Contributor

@per1234
Copy link
Contributor

per1234 commented Apr 25, 2022

Thanks @aentinger!

@per1234 per1234 closed this as completed Apr 25, 2022
@per1234 per1234 added the conclusion: resolved Issue was resolved label Apr 25, 2022
@ivankravets
Copy link
Contributor

Thanks for solving this issue! The library has been updated https://registry.platformio.org/libraries/arduino-libraries/NTPClient

Have a great work week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

4 participants