-
Notifications
You must be signed in to change notification settings - Fork 383
Is there a reason why the 3.2.0 isn't available in PlatformIO? #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Closing as duplicate of #78 Since history showed that maintaining duplicate metadata files is not feasible and PlatformIO has support for Arduino's |
@per1234 could we ask you to bump v3.2.1? The v3.2.0 tag is broken, there are multiple manifests with different "version" fields. See https://github.com/arduino-libraries/NTPClient/tree/3.2.0 arduino-libraries/NTPClient in PlatformIO Registry still points to the 3.1.0. |
Hi @ivankravets. I'm not really in the role to make releases of this project, but I will reopen the issue since it seems it is distinct from #78 after all. That will allow us to more effectively track the issue. |
Thanks, @per1234 The same issue with https://github.com/arduino-libraries/ArduinoHttpClient , the I agree with you, it makes sense to remove "library.json" files from the libraries from this org if you don't need advanced control over the library build process. Who could help with this? |
Thanks for bringing that to our attention. I have submitted a PR to address the issue: arduino-libraries/ArduinoHttpClient#133
I have assigned the issue to @aentinger since I see they have been the most actively involved with the project recently. |
I'm a bit confused here. It sounds to me the best way forward would be to drop this line and then make a new release, i.e. v3.2.1? Please note that we do not control what platform.io does or does not do 🤷 . |
@aentinger the problem was caused by this line: https://github.com/arduino-libraries/NTPClient/blob/3.2.0/library.json#L21 "version": "3.1.0", It was not updated before the creation of the 3.2.0 tag in this repository, which caused the 3.2.0 tag to be rejected by the PlatformIO library manager. So PlatformIO users only have access to the old version from the time of the 3.1.0 tag. The problem has since been fixed by the removal of the improperly maintained But there has not been a tag since that fix was made, so the fix hasn't actually taken effect yet. That will only happen when a new release of the library is made:
PlatformIO supports the library.properties metadata file. So the only thing that needs to be done is for us to maintain the file as is required by the Arduino Library Manager and PlatformIO will be able to work with that no problem. The previous problem was caused by the presence of PlatformIO's preferred |
Thank you for the explanation 👍 The thing that got me confused was that I could not find the library.json file anymore, which from the messages I learned was the apparent offender. Will follow your suggestions 👍 |
Should be fixed, see https://github.com/arduino-libraries/NTPClient/releases/tag/3.2.1 🙇 |
Thanks @aentinger! |
Thanks for solving this issue! The library has been updated https://registry.platformio.org/libraries/arduino-libraries/NTPClient Have a great work week! |
In PlatformIO, I get only the 3.1.0 :-(
The text was updated successfully, but these errors were encountered: