Skip to content

Cleanup the key handling code in the editor #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lmihalkovic opened this issue Nov 14, 2015 · 5 comments
Closed

Cleanup the key handling code in the editor #4146

lmihalkovic opened this issue Nov 14, 2015 · 5 comments
Assignees
Labels
Type: Duplicate Another item already exists for this topic
Milestone

Comments

@lmihalkovic
Copy link

There are a number of open issues that can be traced to a few problems with the configuration of the code editor. This task is to address the core issue and remove the hacks. The cleanup will allow

  • switching to the latest version of the RTA lib (i am using the MASTER branch without issues so far - I also removed the patches to allow running the version directly from the distribution instead of having to patch things up for ArduinoIDE each time)
  • fixing some of the navigation issues (nextTab/prevTab...)
  • support for clean management of key bindings (Provide configurable key bindings #4086 - even if this is just to be able to list them all)

note: the situation is still controllable and the removal work is still not too overwhelming, but it is the right time to remove the cruft, and new features will come almost for free.

As Brian Goetz likes to put it (nothing wrong with that):

Yesterday's solutions are today's problems
@matthijskooijman
Copy link
Collaborator

With RTA you mean RsyntaxTextArea, I presume? AFAIK there is only a single change made to that library to help with the undomanager (see this repository). Are you saying this change is no longer needed or integrated in RTA master?

You talk about issues with key handling, can you be more specific about what issues you are referring to?

@ffissore
Copy link
Contributor

Once again, thank you @lmihalkovic However, you yourself mentioned the issues the already existing issues. Hence this issue is a duplicate. Moreover, we already use the latest version of RTA, which is version 2.5.8 https://github.com/bobbylight/RSyntaxTextArea/releases. And no, we won't use its master branch: we already have enough issue to deal with.

@ffissore ffissore added the Type: Duplicate Another item already exists for this topic label Nov 16, 2015
@ffissore ffissore added this to the Release 1.6.7 milestone Nov 16, 2015
@ffissore ffissore self-assigned this Nov 16, 2015
@lmihalkovic
Copy link
Author

@ffissore I can imagine how difficult it seem to handle the maintenance. I hope that at some point you get to have the time and space to see that some of the open issues would go away by removing code, rather than adding more short term fixes.

NOTE: master works just fine.

@lmihalkovic
Copy link
Author

Cleaning up would be nice in order to support clean binding management, but it is possible to at least display things without too much headaches

qa-keys

@lmihalkovic
Copy link
Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Duplicate Another item already exists for this topic
Projects
None yet
Development

No branches or pull requests

3 participants