Skip to content

Commit d2a8109

Browse files
sandeepmistryfacchinm
authored andcommitted
Move global twi vars into .c and make static
1 parent c2662e3 commit d2a8109

File tree

2 files changed

+29
-33
lines changed

2 files changed

+29
-33
lines changed

Diff for: libraries/Wire/src/utility/twi.c

+29
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,35 @@
2323
#include "twi.h"
2424
#include "Arduino.h"
2525

26+
/* Master variables */
27+
static register8_t master_slaveAddress; /*!< Slave address */
28+
static register8_t* master_writeData; /*!< Data to write */
29+
static register8_t* master_readData; /*!< Read data */
30+
static register8_t master_bytesToWrite; /*!< Number of bytes to write */
31+
static register8_t master_bytesToRead; /*!< Number of bytes to read */
32+
static register8_t master_bytesWritten; /*!< Number of bytes written */
33+
static register8_t master_bytesRead; /*!< Number of bytes read */
34+
static register8_t master_sendStop; /*!< To send a stop at the end of the transaction or not */
35+
static register8_t master_trans_status; /*!< Status of transaction */
36+
static register8_t master_result; /*!< Result of transaction */
37+
38+
/* Slave variables */
39+
static uint8_t (*TWI_onSlaveTransmit)(void) __attribute__((unused));
40+
static void (*TWI_onSlaveReceive)(int) __attribute__((unused));
41+
static register8_t* slave_writeData;
42+
static register8_t* slave_readData;
43+
static register8_t slave_bytesToWrite;
44+
static register8_t slave_bytesWritten;
45+
static register8_t slave_bytesToRead;
46+
static register8_t slave_bytesRead;
47+
static register8_t slave_trans_status;
48+
static register8_t slave_result;
49+
static register8_t slave_callUserReceive;
50+
static register8_t slave_callUserRequest;
51+
52+
/* TWI module mode */
53+
static volatile TWI_MODE_t twi_mode;
54+
2655
/*! \brief Initialize the TWI module as a master.
2756
*
2857
* TWI master initialization function.

Diff for: libraries/Wire/src/utility/twi.h

-33
Original file line numberDiff line numberDiff line change
@@ -69,39 +69,6 @@ typedef enum TWI_MODE_enum {
6969
#define ADD_READ_BIT(address) (address | 0x01)
7070
#define ADD_WRITE_BIT(address) (address & ~0x01)
7171

72-
/* Master variables */
73-
register8_t master_slaveAddress; /*!< Slave address */
74-
register8_t* master_writeData; /*!< Data to write */
75-
register8_t* master_readData; /*!< Read data */
76-
register8_t master_bytesToWrite; /*!< Number of bytes to write */
77-
register8_t master_bytesToRead; /*!< Number of bytes to read */
78-
register8_t master_bytesWritten; /*!< Number of bytes written */
79-
register8_t master_bytesRead; /*!< Number of bytes read */
80-
register8_t master_sendStop; /*!< To send a stop at the end of the transaction or not */
81-
register8_t master_trans_status; /*!< Status of transaction */
82-
register8_t master_result; /*!< Result of transaction */
83-
84-
/* Slave variables */
85-
static uint8_t (*TWI_onSlaveTransmit)(void) __attribute__((unused));
86-
static void (*TWI_onSlaveReceive)(int) __attribute__((unused));
87-
register8_t* slave_writeData;
88-
register8_t* slave_readData;
89-
register8_t slave_bytesToWrite;
90-
register8_t slave_bytesWritten;
91-
register8_t slave_bytesToRead;
92-
register8_t slave_bytesRead;
93-
register8_t slave_trans_status;
94-
register8_t slave_result;
95-
register8_t slave_callUserReceive;
96-
register8_t slave_callUserRequest;
97-
register8_t slave_mode;
98-
99-
/* Both */
100-
register8_t *user_readDataBuf;
101-
102-
/* TWI module mode */
103-
volatile TWI_MODE_t twi_mode;
104-
10572
void TWI_MasterInit(uint32_t frequency);
10673
void TWI_SlaveInit(uint8_t address);
10774
void TWI_Flush(void);

0 commit comments

Comments
 (0)