Revert "make fqbn flag required, so that the completion suggests it when pressing <tab><tab>"

umbynos · umbynos · commit 180d1d407568 · 2021-09-13T15:00:02.000+02:00
This reverts commit cc81265.
diff --git a/cli/compile/compile.go b/cli/compile/compile.go
@@ -83,7 +83,6 @@ func NewCommand() *cobra.Command {
 	}
 
 	command.Flags().StringVarP(&fqbn, "fqbn", "b", "", tr("Fully Qualified Board Name, e.g.: arduino:avr:uno"))
-	command.MarkFlagRequired("fqbn")
 	command.RegisterFlagCompletionFunc("fqbn", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 		return getBoards(toComplete), cobra.ShellCompDirectiveDefault
 	})

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ func NewCommand() *cobra.Command {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`command.Flags().StringVarP(&fqbn, "fqbn", "b", "", tr("Fully Qualified Board Name, e.g.: arduino:avr:uno"))`
`86`		`- command.MarkFlagRequired("fqbn")`
`87`	`86`	`command.RegisterFlagCompletionFunc("fqbn", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {`
`88`	`87`	`return getBoards(toComplete), cobra.ShellCompDirectiveDefault`
`89`	`88`	`})`