Migrate TestCoreInstallEsp32 from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -16,6 +16,8 @@
 package core_test
 
 import (
+	"crypto/md5"
+	"encoding/hex"
 	"fmt"
 	"runtime"
 	"sort"
@@ -237,6 +239,32 @@ func TestCoreInstallWithoutUpdateIndex(t *testing.T) {
 	require.Contains(t, string(stdout), "Downloading index: package_index.tar.bz2 downloaded")
 }
 
+func TestCoreInstallEsp32(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// update index
+	url := "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
+	_, _, err := cli.Run("core", "update-index", "--additional-urls="+url)
+	require.NoError(t, err)
+	// install 3rd-party core
+	_, _, err = cli.Run("core", "install", "esp32:[email protected]", "--additional-urls="+url)
+	require.NoError(t, err)
+	// create a sketch and compile to double check the core was successfully installed
+	sketchName := "test_core_install_esp32"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+	_, _, err = cli.Run("compile", "-b", "esp32:esp32:esp32", sketchPath.String())
+	require.NoError(t, err)
+	// prevent regressions for https://github.com/arduino/arduino-cli/issues/163
+	md5 := md5.Sum(([]byte(sketchPath.String())))
+	sketchPathMd5 := strings.ToUpper(hex.EncodeToString(md5[:]))
+	require.NotEmpty(t, sketchPathMd5)
+	buildDir := paths.TempDir().Join("arduino-sketch-" + sketchPathMd5)
+	require.FileExists(t, buildDir.Join(sketchName+".ino.partitions.bin").String())
+}
+
 func TestCoreDownload(t *testing.T) {
 	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
 	defer env.CleanUp()

test/test_core.py

@@ -26,27 +26,6 @@
 import semver
 
 
-@pytest.mark.skipif(
-    platform.system() == "Windows",
-    reason="core fails with fatal error: bits/c++config.h: No such file or directory",
-)
-def test_core_install_esp32(run_command, data_dir):
-    # update index
-    url = "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
-    assert run_command(["core", "update-index", f"--additional-urls={url}"])
-    # install 3rd-party core
-    assert run_command(["core", "install", "esp32:[email protected]", f"--additional-urls={url}"])
-    # create a sketch and compile to double check the core was successfully installed
-    sketch_name = "test_core_install_esp32"
-    sketch_path = os.path.join(data_dir, sketch_name)
-    assert run_command(["sketch", "new", sketch_path])
-    assert run_command(["compile", "-b", "esp32:esp32:esp32", sketch_path])
-    # prevent regressions for https://github.com/arduino/arduino-cli/issues/163
-    sketch_path_md5 = hashlib.md5(sketch_path.encode()).hexdigest().upper()
-    build_dir = Path(tempfile.gettempdir(), f"arduino-sketch-{sketch_path_md5}")
-    assert (build_dir / f"{sketch_name}.ino.partitions.bin").exists()
-
-
 def test_core_install_creates_installed_json(run_command, data_dir):
     assert run_command(["core", "update-index"])
     assert run_command(["core", "install", "arduino:[email protected]"])