Skip to content

Commit c21f361

Browse files
Migrated TestBoardSearchWithOutdatedCore to board_test.go and deleted test_board.py
1 parent 55dde2d commit c21f361

File tree

2 files changed

+32
-44
lines changed

2 files changed

+32
-44
lines changed

internal/integrationtest/board/board_test.go

+32
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@
1616
package board_test
1717

1818
import (
19+
"encoding/json"
1920
"os"
2021
"strings"
2122
"testing"
2223

2324
"github.com/arduino/arduino-cli/internal/integrationtest"
2425
"github.com/stretchr/testify/require"
26+
semver "go.bug.st/relaxed-semver"
2527
"go.bug.st/testifyjson/requirejson"
2628
"gopkg.in/src-d/go-git.v4"
2729
"gopkg.in/src-d/go-git.v4/plumbing"
@@ -448,3 +450,33 @@ func TestBoardAttachWithoutSketchJson(t *testing.T) {
448450
_, _, err = cli.Run("board", "attach", "-b", fqbn, sketchPath.String())
449451
require.NoError(t, err)
450452
}
453+
454+
func TestBoardSearchWithOutdatedCore(t *testing.T) {
455+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
456+
defer env.CleanUp()
457+
458+
_, _, err := cli.Run("update")
459+
require.NoError(t, err)
460+
461+
// Install an old core version
462+
_, _, err = cli.Run("core", "install", "arduino:[email protected]")
463+
require.NoError(t, err)
464+
465+
stdout, _, err := cli.Run("board", "search", "arduino:samd:mkrwifi1010", "--format", "json")
466+
require.NoError(t, err)
467+
requirejson.Len(t, stdout, 1)
468+
var data []map[string]interface{}
469+
err = json.Unmarshal(stdout, &data)
470+
require.NoError(t, err)
471+
board := data[0]
472+
require.Equal(t, board["name"], "Arduino MKR WiFi 1010")
473+
require.Equal(t, board["fqbn"], "arduino:samd:mkrwifi1010")
474+
samdCore := board["platform"].(map[string]interface{})
475+
require.Equal(t, samdCore["id"], "arduino:samd")
476+
installedVersion, err := semver.Parse(samdCore["installed"].(string))
477+
require.NoError(t, err)
478+
latestVersion, err := semver.Parse(samdCore["latest"].(string))
479+
require.NoError(t, err)
480+
// Installed version must be older than latest
481+
require.True(t, installedVersion.LessThan(latestVersion))
482+
}

test/test_board.py

-44
This file was deleted.

0 commit comments

Comments
 (0)