Skip to content

Remove/refactor legacy i18n.Logger #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmaglie opened this issue Jan 13, 2022 · 0 comments · Fixed by #1625
Closed

Remove/refactor legacy i18n.Logger #1623

cmaglie opened this issue Jan 13, 2022 · 0 comments · Fixed by #1625
Assignees
@cmaglie
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@cmaglie
Copy link
Member

cmaglie commented Jan 13, 2022

This is mainly used in the arduino-builder to transfer "messages" and translate them on the Arduino IDE 1.8.x side. After removing the i18n.Logger will have the effect to "lose" the translations already made for the Arduino IDE (because the IDE will not be able anymore to translate them), we should find a way to move the already translated strings from the IDE 1.8 to the arduino-cli.
@cmaglie cmaglie self-assigned this Jan 13, 2022
@silvanocerza silvanocerza added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Jan 13, 2022
@per1234 per1234 mentioned this issue Jan 14, 2022
Merged
5 tasks
@cmaglie cmaglie linked a pull request Jan 14, 2022 that will close this issue
[breaking] legacy: refactoring of the old Logger (part 2 of 2) #1625
Merged
5 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[breaking] legacy: refactoring of the old Logger (part 2 of 2) cmaglie/arduino-cli
3 participants
@cmaglie @silvanocerza @per1234