fix: encoding when reading a cloud sketch

Akos Kitta · Akos Kitta · commit 402a7e7d6cc2 · 2023-02-22T16:11:09.000+01:00
Closes #449 Closes #634 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
diff --git a/arduino-ide-extension/src/browser/create/create-fs-provider.ts b/arduino-ide-extension/src/browser/create/create-fs-provider.ts
@@ -154,7 +154,9 @@ export class CreateFsProvider
 
   async readFile(uri: URI): Promise<Uint8Array> {
     const content = await this.getCreateApi.readFile(uri.path.toString());
-    return new TextEncoder().encode(content);
+    // Text encoder can crash in electron browser: https://github.com/arduino/arduino-ide/issues/634#issuecomment-1440039171
+    // Credit for the workaround: https://stackoverflow.com/a/45722000/5529090
+    return Uint8Array.from(content, (char) => char.charCodeAt(0));
   }
 
   async writeFile(

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,9 @@ export class CreateFsProvider`
`154`	`154`
`155`	`155`	`async readFile(uri: URI): Promise<Uint8Array> {`
`156`	`156`	`const content = await this.getCreateApi.readFile(uri.path.toString());`
`157`		`- return new TextEncoder().encode(content);`
	`157`	`+ // Text encoder can crash in electron browser: https://github.com/arduino/arduino-ide/issues/634#issuecomment-1440039171`
	`158`	`+ // Credit for the workaround: https://stackoverflow.com/a/45722000/5529090`
	`159`	`+ return Uint8Array.from(content, (char) => char.charCodeAt(0));`
`158`	`160`	`}`
`159`	`161`
`160`	`162`	`async writeFile(`