Skip to content

Commit 6adde6b

Browse files
author
Akos Kitta
committed
fix: workaround for non-functional Edit menu items
Set menu item roles on all supported OSs, not only macOS. Signed-off-by: Akos Kitta <[email protected]>
1 parent 682f2cc commit 6adde6b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Diff for: arduino-ide-extension/src/electron-browser/theia/core/electron-main-menu-factory.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -262,12 +262,12 @@ export class ElectronMainMenuFactory extends TheiaElectronMainMenuFactory {
262262
execute: () => this.execute(commandId, args, options.rootMenuPath),
263263
};
264264

265-
if (isOSX) {
266-
const role = this.roleFor(node.id);
267-
if (role) {
268-
menuItem.role = role;
269-
delete menuItem.execute;
270-
}
265+
// Do not restrict menu item roles for macOS
266+
// https://github.com/eclipse-theia/theia/issues/12487
267+
const role = this.roleFor(node.id);
268+
if (role) {
269+
menuItem.role = role;
270+
delete menuItem.execute;
271271
}
272272
parentItems.push(menuItem);
273273

0 commit comments

Comments
 (0)