Skip to content

Commit fb690c9

Browse files
author
Alberto Iannaccone
authored
Fix settings dialog size (#1172)
* give an id to the settings dialog to grant higher priority to css rule to fix the max-width * fix settings dialog height
1 parent a003831 commit fb690c9

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

arduino-ide-extension/src/browser/dialogs/settings/settings-dialog.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class SettingsDialog extends AbstractDialog<Promise<Settings>> {
6363
protected override readonly props: SettingsDialogProps
6464
) {
6565
super(props);
66-
this.node.classList.add('arduino-settings-dialog-container');
66+
this.node.id = 'arduino-settings-dialog-container';
6767
this.contentNode.classList.add('arduino-settings-dialog');
6868
this.appendCloseButton(
6969
nls.localize('vscode/issueMainService/cancel', 'Cancel')

arduino-ide-extension/src/browser/style/settings-dialog.css

+7-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
1-
.arduino-settings-dialog-container > .dialogBlock {
2-
width: calc(100% - 96px);
1+
#arduino-settings-dialog-container > .dialogBlock {
2+
height: 531px;;
33
max-width: 740px !important;
4+
width: calc(100% - 96px);
5+
}
6+
7+
#arduino-settings-dialog-container > .dialogBlock > .dialogContent {
8+
justify-content: flex-start;
49
}
510

611
.arduino-settings-dialog .content {

0 commit comments

Comments
 (0)