Merge pull request #27 from arduino/generic-filter

Added generic filtering function for PathList

Author: cmaglie

Diff for: list.go

@@ -91,10 +91,12 @@ func (p *PathList) FilterOutHiddenFiles() {
 	p.FilterOutPrefix(".")
 }
 
-func (p *PathList) filter(filter func(*Path) bool) {
+// Filter will remove all the elements of the list that do not match
+// the specified acceptor function
+func (p *PathList) Filter(acceptorFunc func(*Path) bool) {
 	res := (*p)[:0]
 	for _, path := range *p {
-		if filter(path) {
+        if acceptorFunc(path) {
 			res = append(res, path)
 		}
 	}
@@ -106,31 +108,31 @@ func (p *PathList) FilterOutPrefix(prefixes ...string) {
 	filterFunction := func(path *Path) bool {
 		return !path.HasPrefix(prefixes...)
 	}
-	p.filter(filterFunction)
+	p.Filter(filterFunction)
 }
 
 // FilterPrefix remove all entries not having one of the specified prefixes
 func (p *PathList) FilterPrefix(prefixes ...string) {
 	filterFunction := func(path *Path) bool {
 		return path.HasPrefix(prefixes...)
 	}
-	p.filter(filterFunction)
+	p.Filter(filterFunction)
 }
 
 // FilterOutSuffix remove all entries having one of the specified suffixes
 func (p *PathList) FilterOutSuffix(suffixies ...string) {
 	filterFunction := func(path *Path) bool {
 		return !path.HasSuffix(suffixies...)
 	}
-	p.filter(filterFunction)
+	p.Filter(filterFunction)
 }
 
 // FilterSuffix remove all entries not having one of the specified suffixes
 func (p *PathList) FilterSuffix(suffixies ...string) {
 	filterFunction := func(path *Path) bool {
 		return path.HasSuffix(suffixies...)
 	}
-	p.filter(filterFunction)
+	p.Filter(filterFunction)
 }
 
 // Add adds a Path to the PathList

Diff for: list_test.go

@@ -160,4 +160,10 @@ func TestListFilters(t *testing.T) {
 	l16 := list.Clone()
 	l16.FilterPrefix()
 	require.Equal(t, "[]", fmt.Sprintf("%s", l16))
+
+	l17 := list.Clone()
+	l17.Filter(func(p *Path) bool {
+		return p.Base() == "bbbb"
+	})
+	require.Equal(t, "[bbbb aaaa/bbbb]", fmt.Sprintf("%s", l17))
 }