Skip to content

Commit 57289ee

Browse files
authored
Merge pull request #82 from per1234/recommended-request-headers
Use all recommended headers in GitHub API HTTP requests
2 parents 8a0046b + 01f5811 commit 57289ee

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

Diff for: reportsizedeltas/reportsizedeltas.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -625,8 +625,13 @@ def raw_http_request(self, url: str, data: bytes | None = None):
625625

626626
logger.info("Opening URL: " + url)
627627

628-
# GitHub recommends using user name as User-Agent (https://developer.github.com/v3/#user-agent-required)
629-
headers = {"Authorization": "token " + self.token, "User-Agent": self.repository_name.split("/")[0]}
628+
headers = {
629+
"Accept": "application/vnd.github+json",
630+
"Authorization": "Bearer " + self.token,
631+
# GitHub recommends using user name as User-Agent (https://developer.github.com/v3/#user-agent-required)
632+
"User-Agent": self.repository_name.split("/")[0],
633+
"X-GitHub-Api-Version": "2022-11-28",
634+
}
630635
request = urllib.request.Request(url=url, headers=headers, data=data)
631636

632637
retry_count = 0

Diff for: reportsizedeltas/tests/test_reportsizedeltas.py

+8-1
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,14 @@ def test_raw_http_request(mocker):
888888
report_size_deltas.raw_http_request(url=url, data=data)
889889

890890
urllib.request.Request.assert_called_once_with(
891-
url=url, headers={"Authorization": "token " + token, "User-Agent": user_name}, data=data
891+
url=url,
892+
headers={
893+
"Accept": "application/vnd.github+json",
894+
"Authorization": "Bearer " + token,
895+
"User-Agent": user_name,
896+
"X-GitHub-Api-Version": "2022-11-28",
897+
},
898+
data=data,
892899
)
893900
# URL is subject to GitHub API rate limiting
894901
report_size_deltas.handle_rate_limiting.assert_called_once()

0 commit comments

Comments
 (0)