Skip to content

Commit 5cf16d8

Browse files
committed
Remove redundant default version code
The default value of the version input is defined in the action metadata, so having another default setting in the code is purely redundant and doubles the maintenance effort required on every major release of Task (note that they already went out of sync).
1 parent 66af6aa commit 5cf16d8

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ author: "Arduino"
44
inputs:
55
version:
66
description: "Version to use. Example: 3.4.2"
7-
required: false
7+
required: true
88
default: "3.x"
99
repo-token:
1010
description: "Token with permissions to do repo things"

dist/index.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -266,14 +266,9 @@ const installer = __importStar(__nccwpck_require__(1480));
266266
function run() {
267267
return __awaiter(this, void 0, void 0, function* () {
268268
try {
269-
let version = core.getInput("version");
269+
const version = core.getInput("version", { required: true });
270270
const repoToken = core.getInput("repo-token");
271-
if (!version) {
272-
version = "2.x";
273-
}
274-
if (version) {
275-
yield installer.getTask(version, repoToken);
276-
}
271+
yield installer.getTask(version, repoToken);
277272
}
278273
catch (error) {
279274
core.setFailed(error.message);

src/main.ts

+2-7
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,10 @@ import * as installer from "./installer";
1515

1616
async function run() {
1717
try {
18-
let version = core.getInput("version");
18+
const version = core.getInput("version", { required: true });
1919
const repoToken = core.getInput("repo-token");
20-
if (!version) {
21-
version = "2.x";
22-
}
2320

24-
if (version) {
25-
await installer.getTask(version, repoToken);
26-
}
21+
await installer.getTask(version, repoToken);
2722
} catch (error) {
2823
core.setFailed(error.message);
2924
}

0 commit comments

Comments
 (0)