Skip to content

Commit 85dca39

Browse files
committed
Use ncc to compile action
This allows the node_modules to be removed from the repository, as is already done in the `arduino/setup-arduino-cli`, `arduino/arduino-lint-action`, and `arduino/create-changelog` actions.
1 parent 85ad4dc commit 85dca39

File tree

190 files changed

+5060
-14292
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

190 files changed

+5060
-14292
lines changed

.gitignore

+5
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1+
# Dependency directory
2+
node_modules/
3+
4+
# Ignore built ts files
15
__tests__/runner/*
6+
lib/**/*

README.md

+4-8
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,11 @@ See [step-debug-logs](https://github.com/actions/toolkit/blob/master/docs/action
5050

5151
## Release
5252

53-
We check in the `node_modules` to provide runtime dependencies to the system
54-
using the Action, so be careful not to `git add` all the development dependencies
55-
you might have under your local `node_modules`. To release a new version of the
56-
Action the workflow should be the following:
53+
To release a new version of the Action the workflow should be the following:
5754

58-
1. `npm install` to add all the dependencies, included development.
55+
1. `npm install` to install the dependencies.
5956
1. `npm run test` to see everything works as expected.
6057
1. `npm run build` to build the Action under the `./lib` folder.
61-
1. `rm -rf node_modules` to remove all the dependencies.
62-
1. `npm install --production` to add back **only** the runtime dependencies.
63-
1. `git add lib node_modules` to check in the code that matters.
58+
1. `npm run pack` to package for distribution
59+
1. `git add src dist` to check in the code that matters.
6460
1. open a PR and request a review.

action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ inputs:
1010

1111
runs:
1212
using: 'node12'
13-
main: 'lib/main.js'
13+
main: "dist/index.js"

0 commit comments

Comments
 (0)