Skip to content

Commit 888fcbf

Browse files
committed
Update URL of taskfile schema in "Check Taskfiles" workflow
The "Check Taskfiles" template workflow validates the project's taskfiles against the official JSON schema. The contents of that schema was recently moved from the previous location in the Schema Store to the Task project repository: go-task/task#910 An attempt was made to mitigate the impact of that move by replacing the content in the original schema with an external reference to the new one. However, the schema validator used by the workflow does not automatically follow external references, which caused the workflow to fail: schema /home/runner/work/_temp/taskfile-schema/taskfile.json is invalid error: can't resolve reference https://taskfile.dev/schema.json from id # Although this could be resolved by also downloading the referenced schema, since the original schema intentionally does not contain anything of value, the better fix is to simply use the real schema directly in the workflow.
1 parent 8557c04 commit 888fcbf

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/check-taskfiles.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ jobs:
5151
id: download-schema
5252
uses: carlosperate/download-file-action@v2
5353
with:
54-
# See: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json
55-
file-url: https://json.schemastore.org/taskfile.json
54+
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json
55+
file-url: https://taskfile.dev/schema.json
5656
location: ${{ runner.temp }}/taskfile-schema
5757

5858
- name: Install JSON schema validator

workflow-templates/check-taskfiles.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ jobs:
5151
id: download-schema
5252
uses: carlosperate/download-file-action@v2
5353
with:
54-
# See: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json
55-
file-url: https://json.schemastore.org/taskfile.json
54+
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json
55+
file-url: https://taskfile.dev/schema.json
5656
location: ${{ runner.temp }}/taskfile-schema
5757

5858
- name: Install JSON schema validator

workflow-templates/dependabot/workflow-template-copies/.github/workflows/check-taskfiles.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ jobs:
5151
id: download-schema
5252
uses: carlosperate/download-file-action@v2
5353
with:
54-
# See: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json
55-
file-url: https://json.schemastore.org/taskfile.json
54+
# Source: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json
55+
file-url: https://taskfile.dev/schema.json
5656
location: ${{ runner.temp }}/taskfile-schema
5757

5858
- name: Install JSON schema validator

0 commit comments

Comments
 (0)