Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document github app credentials enterprise base url when creating repository #22389

Open
chengfang opened this issue Mar 18, 2025 · 2 comments · May be fixed by #22433
Open

Document github app credentials enterprise base url when creating repository #22389

chengfang opened this issue Mar 18, 2025 · 2 comments · May be fixed by #22433
Assignees
Labels
component:docs enhancement New feature or request

Comments

@chengfang
Copy link
Contributor

Summary

when creating a repository with github app in argocd ui or cli, one of the parameters is the enterprise api base url. From argocd docs https://argo-cd.readthedocs.io/en/stable/user-guide/private-repositories/#github-app-credential, this parameter is not present in either the cli example, or the ui screenshot

Motivation

github app enterprise base url is an important parameter when using github enterprise, and is usually different from the default value https://api.github.com.

Proposal

add this parameter to the cli example, and update the screenshot with one that contains this field.

@chengfang chengfang added the enhancement New feature or request label Mar 18, 2025
@nitishfy nitishfy self-assigned this Mar 18, 2025
@dkarpele
Copy link

Hi @nitishfy, are you working on this issue? If not I can work on it.

@nitishfy
Copy link
Member

sure, please take this up.

@nitishfy nitishfy assigned dkarpele and unassigned nitishfy Mar 19, 2025
dkarpele added a commit to dkarpele/argo-cd that referenced this issue Mar 19, 2025
…ing repository.

Add CLI command to Add a private Git repository on GitHub Enterprise and update instruction.

Resolves: argoproj#22389
Signed-off-by: Denis Karpelevich <[email protected]>
dkarpele added a commit to dkarpele/argo-cd that referenced this issue Mar 20, 2025
…ing repository.

Add CLI command to Add a private Git repository on GitHub Enterprise and update instruction.

Resolves: argoproj#22389
Signed-off-by: Denis Karpelevich <[email protected]>
dkarpele added a commit to dkarpele/argo-cd that referenced this issue Mar 21, 2025
…ing repository.

Add CLI command to Add a private Git repository on GitHub Enterprise and update instruction.

Resolves: argoproj#22389
Signed-off-by: Denis Karpelevich <[email protected]>
dkarpele added a commit to dkarpele/argo-cd that referenced this issue Mar 21, 2025
… creating repository (argoproj#22389)

Add CLI command to Add a private Git repository in GitHub Enterprise and update instruction.

Signed-off-by: Denis Karpelevich <[email protected]>
dkarpele added a commit to dkarpele/argo-cd that referenced this issue Mar 23, 2025
… creating repository (argoproj#22389)

Add CLI command to Add a private Git repository in GitHub Enterprise and update instruction.

Signed-off-by: Denis Karpelevich <[email protected]>
dkarpele added a commit to dkarpele/argo-cd that referenced this issue Mar 24, 2025
… creating repository (argoproj#22389)

Add CLI command to Add a private Git repository in GitHub Enterprise and update instruction.

Signed-off-by: Denis Karpelevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs enhancement New feature or request
Projects
None yet
3 participants