-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Hydrator hydrateTo triggers hydrates every few second #22506
Comments
I think this is two bugs. The first bug is the little error message popping up. The UI component that displays the hydrated SHA doesn't work when the input is HEAD. The UI component should handle the HEAD case correctly. The second bug is the refreshing every 5 seconds. I know there are issues with caching in the hydrator, but nothing that should cause a hydration every 5s. Can you check the logs to see if the hydrator is logging why it's refreshing? Those logs should be in the application-controller component and should have the word "hydrator" somewhere in the log lines. |
After a quick check of the controller I found these logs and it appears every 30 seconds. Sorry seemed faster to me when testing in the Web UI.
|
Hm. That number today is based on the app refresh interval (although long-term it probably should be its own config item). Do you have that configured to 30s? |
Yes that will be it, |
Gotcha. There's definitely more work avoidance that needs to be done there. I explicitly disabled some manifest-related caches (like the refs cache) just to get things running. We need to go back and see how much caching we can re-enable without hitting issues. |
Checklist:
argocd version
.Describe the bug
ArgoCD 2.14.8+a7178be
Helm Chart 7.8.14
I am currently testing the new feature of the source hydrator in a playground repository. So far this application manifest works without any problems
As soon as i add the
hydrateTo
to the manifest, argocd tries to hydrate the branch every ~5 second and i get everytime an error message in the bottom right corner.I followed the steps from this guide and activated the commit server in an existing argocd installation.
Expected behavior
It should only hydrate if changes are really present and without an error message
Version
The text was updated successfully, but these errors were encountered: