Appset doesn't create apps even in clusters with valid secret when secret is invalid for any one of the clusters

[krriteshguptaa]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

Appset controller is not generating applications for clusters with valid valid secret name , when any other cluster connectivity is broken.

To Reproduce

create a cluster secret with invalid secret data

Expected behavior

the generation should just fail for the cluster whose secret is invalid and not for others.

Screenshots

Version

argocd-server: v2.12.0+ec30a48
  BuildDate: 2024-08-05T13:25:54Z
  GitCommit: ec30a48bce7a60046836e481cd2160e28c59231d
  GitTreeState: clean
  GoVersion: go1.22.4
  Compiler: gc
  Platform: linux/amd64
  Kustomize Version: v5.4.2 2024-05-22T15:19:38Z
  Helm Version: v3.15.2+g1a500d5
  Kubectl Version: v0.29.6
  Jsonnet Version: v0.20.0

Logs

https://github.com/argoproj/argo-cd/blob/master/applicationset/utils/clusterUtils.go#L41 , its being caused by this line of the code

Paste any relevant application logs here.

[joshuabezaleel]

This was the specific log that we got

{"applicationset":{"Namespace":"argocd","Name":"k8s-runtime-appset-all"},"level":"error","msg":"validation error found during application validation: application destination spec is invalid: unable to find destination server: unable to convert cluster secret to cluster object 'cluster-k8s.i.<any-cluster-name-from-list-of-clusters>-20250205103432': invalid character 'b' looking for beginning of object key string","time":"2025-03-28T17:35:59Z"}

[rumstead]

relevant slack - https://cloud-native.slack.com/archives/C01TSERG0KZ/p1743164277625099

[joshuabezaleel]

Not sure whether there's an available command to assign issue to ourselves but I'm interested in taking this one! 😄