fix(controller): rollout stuck in Progressing. fixes #3988 (#4072)

fix rollout stuck in `Progressing`

Signed-off-by: joey <[email protected]>

Author: chengjoey

rollout/bluegreen_test.go

@@ -1406,6 +1406,7 @@ func TestBlueGreenReadyToScaleDownOldReplica(t *testing.T) {
 	f.objects = append(f.objects, r2)
 	f.serviceLister = append(f.serviceLister, s)
 
+	f.expectPatchReplicaSetAction(rs2)
 	updatedRSIndex := f.expectUpdateReplicaSetAction(rs2)
 	patchIndex := f.expectPatchRolloutAction(r2)
 	f.run(getKey(r2, t))

rollout/replicaset.go

@@ -107,6 +107,16 @@ func (c *rolloutContext) removeScaleDownDeadlines() error {
 			toRemove = append(toRemove, c.stableRS)
 		}
 	}
+	for _, rs := range c.otherRSs {
+		remainScaleDownDeadlines, err := replicasetutil.GetTimeRemainingBeforeScaleDownDeadline(rs)
+		if err != nil {
+			c.log.Warnf("%v", err)
+			continue
+		}
+		if replicasetutil.HasScaleDownDeadline(rs) && remainScaleDownDeadlines == nil {
+			toRemove = append(toRemove, rs)
+		}
+	}
 	for _, rs := range toRemove {
 		err := c.removeScaleDownDelay(rs)
 		if err != nil {