refactor: fix impossible parse_url equality (felixfbecker#676)

muglug · felixfbecker · commit ed2d8ddb1eff · 2018-11-11T04:47:10.000+01:00
`parse_url` returns `false` for malformed urls, not `null`
diff --git a/src/utils.php b/src/utils.php
@@ -38,7 +38,7 @@ function pathToUri(string $filepath): string
 function uriToPath(string $uri)
 {
     $fragments = parse_url($uri);
-    if ($fragments === null || !isset($fragments['scheme']) || $fragments['scheme'] !== 'file') {
+    if ($fragments === false || !isset($fragments['scheme']) || $fragments['scheme'] !== 'file') {
         throw new InvalidArgumentException("Not a valid file URI: $uri");
     }
     $filepath = urldecode($fragments['path']);

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ function pathToUri(string $filepath): string`
`38`	`38`	`function uriToPath(string $uri)`
`39`	`39`	`{`
`40`	`40`	`$fragments = parse_url($uri);`
`41`		`- if ($fragments === null \|\| !isset($fragments['scheme']) \|\| $fragments['scheme'] !== 'file') {`
	`41`	`+ if ($fragments === false \|\| !isset($fragments['scheme']) \|\| $fragments['scheme'] !== 'file') {`
`42`	`42`	`throw new InvalidArgumentException("Not a valid file URI: $uri");`
`43`	`43`	`}`
`44`	`44`	`$filepath = urldecode($fragments['path']);`