Merge pull request swiftlang#74840 from drexin/wip-130781414

[IRGen] Properly convert between ptr and int in typed error mapping

Author: drexin

lib/IRGen/GenCall.cpp

@@ -414,10 +414,13 @@ CombinedResultAndErrorType irgen::combineResultAndTypedErrorType(
     assert(error->isIntOrPtrTy() &&
            "Direct errors must only consist of int or ptr values");
     result.errorValueMapping.push_back(combined.size());
-    if (res->getPrimitiveSizeInBits() >= error->getPrimitiveSizeInBits()) {
+
+    if (res == error) {
       combined.push_back(res);
     } else {
-      combined.push_back(error);
+      auto maxSize = std::max(IGM.DataLayout.getTypeSizeInBits(res),
+                              IGM.DataLayout.getTypeSizeInBits(error));
+      combined.push_back(llvm::IntegerType::get(IGM.getLLVMContext(), maxSize));
     }
 
     ++resIt;
@@ -2864,10 +2867,12 @@ class SyncCallEmission final : public CallEmission {
         if (auto *structTy = dyn_cast<llvm::StructType>(
                 nativeSchema.getExpandedType(IGF.IGM))) {
           for (unsigned i = 0, e = structTy->getNumElements(); i < e; ++i) {
-            resultExplosion.add(values[i]);
+            auto *nativeTy = structTy->getElementType(i);
+            resultExplosion.add(convertIfNecessary(nativeTy, values[i]));
           }
         } else {
-          resultExplosion.add(values[0]);
+          resultExplosion.add(
+              convertIfNecessary(combined.combinedTy, values[0]));
         }
         out = nativeSchema.mapFromNative(IGF.IGM, IGF, resultExplosion,
                                          resultType);
@@ -5738,6 +5743,9 @@ void IRGenFunction::emitScalarReturn(SILType returnResultType,
                 eltTy->getPrimitiveSizeInBits()) {
           assert(nativeTy->getPrimitiveSizeInBits() >
                  eltTy->getPrimitiveSizeInBits());
+          if (eltTy->isPointerTy()) {
+            return Builder.CreatePtrToInt(elt, nativeTy);
+          }
           return Builder.CreateZExt(elt, nativeTy);
         }
         return elt;

lib/IRGen/IRGenSIL.cpp

@@ -4460,6 +4460,11 @@ void IRGenSILFunction::visitThrowInst(swift::ThrowInst *i) {
                       eltTy->getPrimitiveSizeInBits()) {
                 assert(nativeTy->getPrimitiveSizeInBits() >
                        eltTy->getPrimitiveSizeInBits());
+
+                if (eltTy->isPointerTy()) {
+                  return elt = Builder.CreatePtrToInt(elt, nativeTy);
+                }
+
                 return Builder.CreateZExt(elt, nativeTy);
               }
               return elt;

test/IRGen/typed_throws.swift

@@ -111,3 +111,19 @@ func catchesSmallError() -> Int {
     return error.x
   }
 }
+
+struct MyError: Error {
+  let x: AnyObject
+}
+
+// CHECK: define hidden swiftcc { float, i64, float } @"$s12typed_throws8mayThrow1x1ySf_s5Int32VSftSb_yXltAA7MyErrorVYKF"
+// CHECK:   [[CONVERTED:%.*]] = ptrtoint ptr {{%.*}} to i64
+// CEHCK:   insertvalue { float, i64, float } undef, i64 [[CONVERTED]], 1
+// CHECK: }
+@inline(never)
+func mayThrow(x: Bool, y: AnyObject) throws(MyError) -> (Float, Int32, Float) {
+  guard x else {
+    throw MyError(x: y)
+  }
+  return (3.0, 4, 5.0)
+}