Skip to content

Commit 64f1271

Browse files
jingyugaoashanbrown
authored andcommitted
rowserrcheck: fix reports false positive (golangci#1670)
1 parent 1ac85ae commit 64f1271

File tree

3 files changed

+30
-5
lines changed

3 files changed

+30
-5
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ require (
3030
github.com/golangci/revgrep v0.0.0-20180526074752-d9c87f5ffaf0
3131
github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4
3232
github.com/jgautheron/goconst v0.0.0-20201117150253-ccae5bf973f3
33-
github.com/jingyugao/rowserrcheck v0.0.0-20191204022205-72ab7603b68a
33+
github.com/jingyugao/rowserrcheck v0.0.0-20210130005344-c6a0c12dd98d
3434
github.com/jirfag/go-printf-func-name v0.0.0-20191110105641-45db9963cdd3
3535
github.com/kulti/thelper v0.2.1
3636
github.com/kunwardeep/paralleltest v1.0.2

go.sum

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/testdata/rowserrcheck.go

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ package testdata
33

44
import (
55
"database/sql"
6+
"fmt"
7+
"math/rand"
68
)
79

810
func RowsErrNotChecked(db *sql.DB) {
@@ -11,3 +13,27 @@ func RowsErrNotChecked(db *sql.DB) {
1113

1214
}
1315
}
16+
17+
func issue943(db *sql.DB) {
18+
var rows *sql.Rows
19+
var err error
20+
21+
if rand.Float64() < 0.5 {
22+
rows, err = db.Query("select 1")
23+
} else {
24+
rows, err = db.Query("select 2")
25+
}
26+
if err != nil {
27+
panic(err)
28+
}
29+
30+
defer rows.Close()
31+
32+
for rows.Next() {
33+
fmt.Println("new rows")
34+
}
35+
36+
if err := rows.Err(); err != nil {
37+
panic(err)
38+
}
39+
}

0 commit comments

Comments
 (0)