Fixes commons-app#3639

* Removed custom save state implementatio of CheckBoxTriState
* Save/Restore CheckBox state in NearbyParentFragment

Author: ashishkumar468

app/src/main/java/fr/free/nrw/commons/nearby/CheckBoxTriStates.java

@@ -1,6 +1,7 @@
 package fr.free.nrw.commons.nearby;
 
 import android.content.Context;
+import android.os.Bundle;
 import android.os.Parcel;
 import android.os.Parcelable;
 import android.util.AttributeSet;
@@ -64,12 +65,6 @@ public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
      */
     private OnCheckedChangeListener clientListener;
 
-    /**
-     * This flag is needed to avoid accidentally changing the current {@link #state} when
-     * {@link #onRestoreInstanceState(Parcelable)} calls {@link #setChecked(boolean)}
-     * evoking our {@link #privateListener} and therefore changing the real state.
-     */
-    private boolean restoring;
 
     public CheckBoxTriStates(Context context) {
         super(context);
@@ -91,7 +86,7 @@ public int getState() {
     }
 
     public void setState(int state) {
-        if(!this.restoring && this.state != state) {
+        if(this.state != state) {
             this.state = state;
 
             if(this.clientListener != null) {
@@ -118,27 +113,6 @@ public void setOnCheckedChangeListener(@Nullable OnCheckedChangeListener listene
         super.setOnCheckedChangeListener(privateListener);
     }
 
-    @Override
-    public Parcelable onSaveInstanceState() {
-        Parcelable superState = super.onSaveInstanceState();
-
-        SavedState ss = new SavedState(superState);
-
-        ss.state = state;
-
-        return ss;
-    }
-
-    @Override
-    public void onRestoreInstanceState(Parcelable state) {
-        this.restoring = true; // indicates that the ui is restoring its state
-        SavedState ss = (SavedState) state;
-        super.onRestoreInstanceState(ss.getSuperState());
-        setState(ss.state);
-        requestLayout();
-        this.restoring = false;
-    }
-
     private void init() {
         state = UNKNOWN;
         updateBtn();
@@ -164,44 +138,4 @@ private void updateBtn() {
         setButtonDrawable(btnDrawable);
 
     }
-
-    static class SavedState extends BaseSavedState {
-        int state;
-
-        SavedState(Parcelable superState) {
-            super(superState);
-        }
-
-        private SavedState(Parcel in) {
-            super(in);
-            state = in.readInt();
-        }
-
-        @Override
-        public void writeToParcel(Parcel out, int flags) {
-            super.writeToParcel(out, flags);
-            out.writeValue(state);
-        }
-
-        @Override
-        public String toString() {
-            return "CheckboxTriState.SavedState{"
-                    + Integer.toHexString(System.identityHashCode(this))
-                    + " state=" + state + "}";
-        }
-
-        @SuppressWarnings("hiding")
-        public static final Parcelable.Creator<SavedState> CREATOR =
-                new Parcelable.Creator<SavedState>() {
-                    @Override
-                    public SavedState createFromParcel(Parcel in) {
-                        return new SavedState(in);
-                    }
-
-                    @Override
-                    public SavedState[] newArray(int size) {
-                        return new SavedState[size];
-                    }
-                };
-    }
 }

app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyListFragment.java

@@ -120,6 +120,7 @@ public class NearbyParentFragment extends CommonsDaggerSupportFragment
         implements NearbyParentFragmentContract.View,
         WikidataEditListener.WikidataP18EditListener, LocationUpdateListener {
 
+    private static final String CHECKBOX_STATE = "checkbox_state";
     @BindView(R.id.bottom_sheet) RelativeLayout rlBottomSheet;
     @BindView(R.id.bottom_sheet_details) View bottomSheetDetails;
     @BindView(R.id.transparentView) View transparentView;
@@ -220,6 +221,12 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
     @Override
     public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
+        //Restore checkbox's state
+        if (null != savedInstanceState) {
+            int checkBoxSavedState = savedInstanceState.getInt(CHECKBOX_STATE,
+                CheckBoxTriStates.UNKNOWN);
+            checkBoxTriStates.setState(checkBoxSavedState);
+        }
         isDarkTheme = systemThemeUtils.isDeviceInNightMode();
         cameraMoveListener= () -> presenter.onCameraMove(mapBox.getCameraPosition().target);
         addCheckBoxCallback();
@@ -363,6 +370,7 @@ public void onStop() {
 
     @Override
     public void onSaveInstanceState(Bundle outState) {
+        outState.putInt(CHECKBOX_STATE,checkBoxTriStates.getState());
         super.onSaveInstanceState(outState);
         mapView.onSaveInstanceState(outState);
     }