Skip to content

Commit 3ab53fd

Browse files
misaochanashishkumar468
authored andcommitted
Versioning for v2.13
1 parent 4b5db57 commit 3ab53fd

File tree

1 file changed

+20
-42
lines changed

1 file changed

+20
-42
lines changed

app/build.gradle

Lines changed: 20 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,17 @@ apply from: 'quality.gradle'
1111

1212
def isRunningOnTravisAndIsNotPRBuild = System.getenv("CI") == "true" && file('../play.p12').exists()
1313

14-
if (isRunningOnTravisAndIsNotPRBuild) {
14+
if(isRunningOnTravisAndIsNotPRBuild) {
1515
apply plugin: 'com.github.triplet.play'
1616
}
1717

1818
dependencies {
1919

20-
implementation project(':wikimedia-data-client')
2120
// Utils
21+
implementation 'com.github.nicolas-raoul:Quadtree:ac16ea8035bf07'
2222
implementation 'in.yuvi:http.fluent:1.3'
2323
implementation 'com.google.code.gson:gson:2.8.5'
24-
implementation ("com.squareup.okhttp3:okhttp:$OKHTTP_VERSION"){
25-
force = true //API 19 support
26-
}
24+
implementation 'com.squareup.okhttp3:okhttp:4.2.0'
2725
implementation 'com.squareup.okio:okio:2.2.2'
2826
implementation 'io.reactivex.rxjava2:rxandroid:2.1.0'
2927
implementation 'io.reactivex.rxjava2:rxjava:2.2.3'
@@ -33,6 +31,7 @@ dependencies {
3331
implementation 'com.jakewharton.rxbinding2:rxbinding-design:2.1.1'
3432
implementation 'com.facebook.fresco:fresco:1.13.0'
3533
implementation 'org.apache.commons:commons-lang3:3.8.1'
34+
implementation 'com.github.maskaravivek:wikimedia-android-data-client:v0.0.30'
3635

3736
// UI
3837
implementation 'fr.avianey.com.viewpagerindicator:library:2.4.1.1@aar'
@@ -45,16 +44,7 @@ dependencies {
4544
implementation 'com.dinuscxj:circleprogressbar:1.1.1'
4645
implementation 'com.karumi:dexter:5.0.0'
4746
implementation "com.jakewharton:butterknife:$BUTTERKNIFE_VERSION"
48-
implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'
49-
5047
kapt "com.jakewharton:butterknife-compiler:$BUTTERKNIFE_VERSION"
51-
implementation "com.hannesdorfmann:adapterdelegates4-kotlin-dsl-layoutcontainer:$ADAPTER_DELEGATES_VERSION"
52-
implementation "com.hannesdorfmann:adapterdelegates4-pagination:$ADAPTER_DELEGATES_VERSION"
53-
implementation "androidx.paging:paging-runtime-ktx:$PAGING_VERSION"
54-
testImplementation "androidx.paging:paging-common-ktx:$PAGING_VERSION"
55-
implementation "androidx.paging:paging-rxjava2-ktx:$PAGING_VERSION"
56-
implementation "androidx.recyclerview:recyclerview:1.2.0-alpha02"
57-
implementation "com.squareup.okhttp3:okhttp-ws:$OKHTTP_VERSION"
5848

5949
// Logging
6050
implementation 'ch.acra:acra-dialog:5.3.0'
@@ -63,7 +53,7 @@ dependencies {
6353
api('com.github.tony19:logback-android-classic:1.1.1-6') {
6454
exclude group: 'com.google.android', module: 'android'
6555
}
66-
implementation "com.squareup.okhttp3:logging-interceptor:$OKHTTP_VERSION"
56+
implementation "com.squareup.okhttp3:logging-interceptor:4.2.0"
6757

6858
// Dependency injector
6959
implementation "com.google.dagger:dagger-android-support:$DAGGER_VERSION"
@@ -75,21 +65,19 @@ dependencies {
7565

7666
//Mocking
7767
testImplementation 'com.nhaarman.mockitokotlin2:mockito-kotlin:2.2.0'
78-
testImplementation 'org.mockito:mockito-inline:2.13.0'
68+
testImplementation 'org.mockito:mockito-inline:2.8.47'
7969
testImplementation 'org.mockito:mockito-core:2.23.0'
8070
testImplementation "org.powermock:powermock-module-junit4:2.0.0-beta.5"
8171
testImplementation "org.powermock:powermock-api-mockito2:2.0.0-beta.5"
8272

8373
// Unit testing
84-
testImplementation 'junit:junit:4.13'
74+
testImplementation 'junit:junit:4.12'
8575
testImplementation 'org.robolectric:robolectric:4.3'
8676
testImplementation 'androidx.test:core:1.2.0'
87-
testImplementation "com.squareup.okhttp3:mockwebserver:$OKHTTP_VERSION"
77+
testImplementation 'com.squareup.okhttp3:mockwebserver:3.12.1'
8878
testImplementation "org.powermock:powermock-module-junit4:2.0.0-beta.5"
8979
testImplementation "org.powermock:powermock-api-mockito2:2.0.0-beta.5"
9080
testImplementation 'org.mockito:mockito-core:2.23.0'
91-
testImplementation "com.jraska.livedata:testing-ktx:1.1.2"
92-
testImplementation "androidx.arch.core:core-testing:2.1.0"
9381

9482
// Android testing
9583
androidTestImplementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$KOTLIN_VERSION"
@@ -99,7 +87,7 @@ dependencies {
9987
androidTestImplementation 'androidx.test:runner:1.2.0'
10088
androidTestImplementation 'androidx.test:rules:1.2.0'
10189
androidTestImplementation 'androidx.annotation:annotation:1.1.0'
102-
androidTestImplementation 'com.squareup.okhttp3:mockwebserver:4.8.0'
90+
androidTestImplementation 'com.squareup.okhttp3:mockwebserver:3.12.1'
10391
androidTestUtil 'androidx.test:orchestrator:1.2.0'
10492

10593
// Debugging
@@ -113,49 +101,43 @@ dependencies {
113101
implementation "androidx.cardview:cardview:1.0.0"
114102
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
115103
implementation "androidx.exifinterface:exifinterface:1.0.0"
116-
implementation "androidx.core:core-ktx:$CORE_KTX_VERSION"
117-
implementation "androidx.multidex:multidex:2.0.1"
118104

119105
//swipe_layout
120106
implementation 'com.daimajia.swipelayout:library:1.2.0@aar'
121107

122108
//Room
123109
implementation "androidx.room:room-runtime:$ROOM_VERSION"
124-
implementation "androidx.room:room-ktx:$ROOM_VERSION"
110+
kapt "androidx.room:room-compiler:$ROOM_VERSION" // For Kotlin use kapt instead of annotationProcessor
111+
implementation 'com.squareup.retrofit2:retrofit:2.7.1'
125112
implementation "androidx.room:room-rxjava2:$ROOM_VERSION"
126-
kapt "androidx.room:room-compiler:$ROOM_VERSION"
127-
// For Kotlin use kapt instead of annotationProcessor
128-
implementation 'com.squareup.retrofit2:retrofit:2.8.1'
129113
testImplementation "androidx.arch.core:core-testing:2.1.0"
130114

131115
// Pref
132116
// Java language implementation
133117
implementation "androidx.preference:preference:$PREFERENCE_VERSION"
134118
// Kotlin
135119
implementation "androidx.preference:preference-ktx:$PREFERENCE_VERSION"
136-
137-
implementation "androidx.multidex:multidex:$MULTIDEX_VERSION"
138120
}
139121

140122
android {
141123
compileSdkVersion 28
124+
buildToolsVersion "28.0.3"
142125

143126
defaultConfig {
144127
//applicationId 'fr.free.nrw.commons'
145-
versionCode 775
146-
versionName '2.13.1'
128+
versionCode 709
129+
versionName '2.13'
147130
setProperty("archivesBaseName", "app-commons-v$versionName-" + getBranchName())
148131

149132
minSdkVersion 19
150133
targetSdkVersion 28
151134
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
152135
testInstrumentationRunnerArguments clearPackageData: 'true'
153136

154-
multiDexEnabled true
155-
156137
testOptions {
157138
execution 'ANDROIDX_TEST_ORCHESTRATOR'
158139
}
140+
159141
vectorDrawables.useSupportLibrary = true
160142
}
161143

@@ -182,7 +164,7 @@ android {
182164
test.resources.srcDirs += 'src/main/resoures'
183165
}
184166

185-
signingConfigs {
167+
signingConfigs {
186168
release
187169
}
188170

@@ -191,7 +173,7 @@ android {
191173
minifyEnabled true
192174
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt'
193175
testProguardFile 'test-proguard-rules.txt'
194-
if (isRunningOnTravisAndIsNotPRBuild) {
176+
if(isRunningOnTravisAndIsNotPRBuild) {
195177
signingConfig signingConfigs.release
196178
}
197179
}
@@ -214,18 +196,17 @@ android {
214196

215197
configurations.all {
216198
resolutionStrategy.force 'androidx.annotation:annotation:1.0.2'
217-
exclude module: 'okhttp-ws'
218199
}
200+
219201
flavorDimensions 'tier'
220202
productFlavors {
221203
prod {
222204

223-
applicationId 'fr.free.nrw.commons'
205+
applicationId 'fr.free.nrw.commons'
224206

225207
buildConfigField "String", "WIKIMEDIA_API_POTD", "\"https://commons.wikimedia.org/w/api.php?action=featuredfeed&feed=potd&feedformat=rss&language=en\""
226208
buildConfigField "String", "WIKIMEDIA_API_HOST", "\"https://commons.wikimedia.org/w/api.php\""
227209
buildConfigField "String", "WIKIDATA_API_HOST", "\"https://www.wikidata.org/w/api.php\""
228-
buildConfigField "String", "WIKIDATA_URL", "\"https://www.wikidata.org\""
229210
buildConfigField "String", "WIKIMEDIA_FORGE_API_HOST", "\"https://tools.wmflabs.org/\""
230211
buildConfigField "String", "WIKIMEDIA_CAMPAIGNS_URL", "\"https://raw.githubusercontent.com/commons-app/campaigns/master/campaigns.json\""
231212
buildConfigField "String", "IMAGE_URL_BASE", "\"https://upload.wikimedia.org/wikipedia/commons\""
@@ -247,7 +228,6 @@ android {
247228
buildConfigField "String", "COMMIT_SHA", "\"" + getBuildVersion().toString() + "\""
248229
buildConfigField "String", "TEST_USERNAME", "\"" + System.getenv("test_user_name") + "\""
249230
buildConfigField "String", "TEST_PASSWORD", "\"" + System.getenv("test_user_password") + "\""
250-
buildConfigField "String", "DEPICTS_PROPERTY", "\"P180\""
251231

252232
dimension 'tier'
253233
}
@@ -259,7 +239,6 @@ android {
259239
buildConfigField "String", "WIKIMEDIA_API_POTD", "\"https://commons.wikimedia.org/w/api.php?action=featuredfeed&feed=potd&feedformat=rss&language=en\""
260240
buildConfigField "String", "WIKIMEDIA_API_HOST", "\"https://commons.wikimedia.beta.wmflabs.org/w/api.php\""
261241
buildConfigField "String", "WIKIDATA_API_HOST", "\"https://www.wikidata.org/w/api.php\""
262-
buildConfigField "String", "WIKIDATA_URL", "\"https://www.wikidata.org\""
263242
buildConfigField "String", "WIKIMEDIA_FORGE_API_HOST", "\"https://tools.wmflabs.org/\""
264243
buildConfigField "String", "WIKIMEDIA_CAMPAIGNS_URL", "\"https://raw.githubusercontent.com/commons-app/campaigns/master/campaigns_beta_active.json\""
265244
buildConfigField "String", "IMAGE_URL_BASE", "\"https://upload.beta.wmflabs.org/wikipedia/commons\""
@@ -281,7 +260,6 @@ android {
281260
buildConfigField "String", "COMMIT_SHA", "\"" + getBuildVersion().toString() + "\""
282261
buildConfigField "String", "TEST_USERNAME", "\"" + System.getenv("test_user_name") + "\""
283262
buildConfigField "String", "TEST_PASSWORD", "\"" + System.getenv("test_user_password") + "\""
284-
buildConfigField "String", "DEPICTS_PROPERTY", "\"P245962\""
285263

286264
dimension 'tier'
287265
}
@@ -301,7 +279,7 @@ android {
301279
buildToolsVersion buildToolsVersion
302280
}
303281

304-
if (isRunningOnTravisAndIsNotPRBuild) {
282+
if(isRunningOnTravisAndIsNotPRBuild) {
305283
play {
306284
track = "alpha"
307285
userFraction = 1

0 commit comments

Comments
 (0)