Fixes commons-app#3920

* Delete stale log files post the zip file's size reaches 1000kb

Author: ashishkumar468

app/src/main/java/fr/free/nrw/commons/CommonsApplication.java

@@ -66,21 +66,21 @@
 import static org.acra.ReportField.USER_COMMENT;
 
 @AcraCore(
-    buildConfigClass = BuildConfig.class,
-    resReportSendSuccessToast = R.string.crash_dialog_ok_toast,
-    reportFormat = StringFormat.KEY_VALUE_LIST,
-    reportContent = {USER_COMMENT, APP_VERSION_CODE, APP_VERSION_NAME, ANDROID_VERSION, PHONE_MODEL, STACK_TRACE}
+        buildConfigClass = BuildConfig.class,
+        resReportSendSuccessToast = R.string.crash_dialog_ok_toast,
+        reportFormat = StringFormat.KEY_VALUE_LIST,
+        reportContent = {USER_COMMENT, APP_VERSION_CODE, APP_VERSION_NAME, ANDROID_VERSION, PHONE_MODEL, STACK_TRACE}
 )
 
 @AcraMailSender(
-    mailTo = "[email protected]"
+        mailTo = "[email protected]"
 )
 
 @AcraDialog(
-    resTheme = R.style.Theme_AppCompat_Dialog,
-    resText = R.string.crash_dialog_text,
-    resTitle = R.string.crash_dialog_title,
-    resCommentPrompt = R.string.crash_dialog_comment_prompt
+        resTheme = R.style.Theme_AppCompat_Dialog,
+        resText = R.string.crash_dialog_text,
+        resTitle = R.string.crash_dialog_title,
+        resCommentPrompt = R.string.crash_dialog_comment_prompt
 )
 
 public class CommonsApplication extends Application {
@@ -135,9 +135,9 @@ public void onCreate() {
         Mapbox.getInstance(this, getString(R.string.mapbox_commons_app_token));
 
         ApplicationlessInjection
-            .getInstance(this)
-            .getCommonsApplicationComponent()
-            .inject(this);
+                .getInstance(this)
+                .getCommonsApplicationComponent()
+                .inject(this);
 
         AppAdapter.set(new CommonsAppAdapter(sessionManager, defaultPrefs));
 
@@ -155,8 +155,8 @@ public void onCreate() {
 
 //        Set DownsampleEnabled to True to downsample the image in case it's heavy
         ImagePipelineConfig config = ImagePipelineConfig.newBuilder(this)
-            .setDownsampleEnabled(true)
-            .build();
+                .setDownsampleEnabled(true)
+                .build();
         try {
             Fresco.initialize(this, config);
         } catch (Exception e) {
@@ -185,30 +185,52 @@ public void onCreate() {
      *
      */
     private void initTimber() {
-        boolean isBeta = ConfigUtils.isBetaFlavour();
-        String logFileName = isBeta ? "CommonsBetaAppLogs" : "CommonsAppLogs";
-        String logDirectory = LogUtils.getLogDirectory();
-        FileLoggingTree tree = new FileLoggingTree(
-            Log.VERBOSE,
-            logFileName,
-            logDirectory,
-            1000,
-            getFileLoggingThreadPool());
-
-        Timber.plant(tree);
-        Timber.plant(new Timber.DebugTree());
+      boolean isBeta = ConfigUtils.isBetaFlavour();
+      String logFileName =
+          isBeta ? "CommonsBetaAppLogs" : "CommonsAppLogs";
+      String logDirectory = LogUtils.getLogDirectory();
+      //Delete stale logs if they have exceeded the specified size
+      deleteStaleLogs(logFileName, logDirectory);
+
+      FileLoggingTree tree = new FileLoggingTree(
+          Log.VERBOSE,
+          logFileName,
+          logDirectory,
+          1000,
+          getFileLoggingThreadPool());
+
+      Timber.plant(tree);
+      Timber.plant(new Timber.DebugTree());
     }
 
+  /**
+   * Deletes the logs zip file at the specified directory and file locations specified in the
+   * params
+   *
+   * @param logFileName
+   * @param logDirectory
+   */
+  private void deleteStaleLogs(String logFileName, String logDirectory) {
+    try {
+      File file = new File(logDirectory + "/zip/" + logFileName + ".zip");
+      if (file.exists() && file.getTotalSpace() > 1000000) {// In Kbs
+        file.delete();
+      }
+    } catch (Exception e) {
+      Timber.e(e);
+    }
+  }
+
     public static boolean isRoboUnitTest() {
         return "robolectric".equals(Build.FINGERPRINT);
     }
 
     private ThreadPoolService getFileLoggingThreadPool() {
         return new ThreadPoolService.Builder("file-logging-thread")
-            .setPriority(Process.THREAD_PRIORITY_LOWEST)
-            .setPoolSize(1)
-            .setExceptionHandler(new BackgroundPoolExceptionHandler())
-            .build();
+                .setPriority(Process.THREAD_PRIORITY_LOWEST)
+                .setPoolSize(1)
+                .setExceptionHandler(new BackgroundPoolExceptionHandler())
+                .build();
     }
 
     public static void createNotificationChannel(@NonNull Context context) {
@@ -217,7 +239,7 @@ public static void createNotificationChannel(@NonNull Context context) {
             NotificationChannel channel = manager.getNotificationChannel(NOTIFICATION_CHANNEL_ID_ALL);
             if (channel == null) {
                 channel = new NotificationChannel(NOTIFICATION_CHANNEL_ID_ALL,
-                    context.getString(R.string.notifications_channel_name_all), NotificationManager.IMPORTANCE_DEFAULT);
+                        context.getString(R.string.notifications_channel_name_all), NotificationManager.IMPORTANCE_DEFAULT);
                 manager.createNotificationChannel(channel);
             }
         }
@@ -238,7 +260,7 @@ protected RefWatcher setupLeakCanary() {
         return LeakCanary.install(this);
     }
 
-    /**
+  /**
      * Provides a way to get member refWatcher
      *
      * @param context Application context
@@ -269,12 +291,12 @@ public void clearApplicationData(Context context, LogoutListener logoutListener)
 
         sessionManager.logout()
             .andThen(Completable.fromAction(() ->{
-                    Timber.d("All accounts have been removed");
-                    clearImageCache();
-                    //TODO: fix preference manager
-                    defaultPrefs.clearAll();
-                    defaultPrefs.putBoolean("firstrun", false);
-                    updateAllDatabases();
+                Timber.d("All accounts have been removed");
+                clearImageCache();
+                //TODO: fix preference manager
+                defaultPrefs.clearAll();
+                defaultPrefs.putBoolean("firstrun", false);
+                updateAllDatabases();
                 }
             ))
             .subscribeOn(Schedulers.io())