DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception (commons-app#3830)

* Fixes commons-app#3829
* DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception

* removed unused imports, handled possible exceptions

* Let Fresco handle the downsampling of image

* invalidate in onTransformEnd

* Expose an interface TransformationListener in ZoomableDraweeView to listen to transformation change end

* removed photoView dependency

* removed unused imports in ZoomableActivity

* Bugfix, expand/collapse

* changed functio name

Author: ashishkumar468

app/build.gradle

@@ -37,7 +37,6 @@ dependencies {
 
     // UI
     implementation 'fr.avianey.com.viewpagerindicator:library:2.4.1.1@aar'
-    implementation 'com.github.chrisbanes:PhotoView:2.0.0'
     implementation 'com.github.pedrovgs:renderers:3.3.3'
     implementation 'com.mapbox.mapboxsdk:mapbox-android-sdk:8.6.2'
     implementation 'com.mapbox.mapboxsdk:mapbox-android-plugin-localization-v8:0.11.0'

app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.java

@@ -4,6 +4,7 @@
 
 import android.annotation.SuppressLint;
 import android.content.Context;
+import android.net.Uri;
 import android.os.Bundle;
 import android.text.TextUtils;
 import android.util.DisplayMetrics;
@@ -23,13 +24,19 @@
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import butterknife.OnClick;
-import com.github.chrisbanes.photoview.PhotoView;
+import com.facebook.drawee.backends.pipeline.Fresco;
+import com.facebook.drawee.drawable.ScalingUtils.ScaleType;
+import com.facebook.drawee.generic.GenericDraweeHierarchy;
+import com.facebook.drawee.generic.GenericDraweeHierarchyBuilder;
+import com.facebook.drawee.interfaces.DraweeController;
 import com.jakewharton.rxbinding2.widget.RxTextView;
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.Utils;
 import fr.free.nrw.commons.filepicker.UploadableFile;
 import fr.free.nrw.commons.kvstore.JsonKvStore;
 import fr.free.nrw.commons.location.LatLng;
+import fr.free.nrw.commons.media.zoomControllers.zoomable.DoubleTapGestureListener;
+import fr.free.nrw.commons.media.zoomControllers.zoomable.ZoomableDraweeView;
 import fr.free.nrw.commons.nearby.Place;
 import fr.free.nrw.commons.settings.Prefs;
 import fr.free.nrw.commons.upload.Description;
@@ -44,6 +51,7 @@
 import fr.free.nrw.commons.utils.ImageUtils;
 import fr.free.nrw.commons.utils.ViewUtil;
 import io.reactivex.disposables.Disposable;
+import java.io.File;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -69,7 +77,7 @@ public class UploadMediaDetailFragment extends UploadBaseFragment implements
     @BindView(R.id.rv_descriptions)
     RecyclerView rvDescriptions;
     @BindView(R.id.backgroundImage)
-    PhotoView photoViewBackgroundImage;
+    ZoomableDraweeView photoViewBackgroundImage;
     @BindView(R.id.btn_next)
     AppCompatButton btnNext;
     @BindView(R.id.btn_previous)
@@ -164,11 +172,26 @@ private void init() {
             btnCopyPreviousTitleDesc.setVisibility(View.VISIBLE);
         }
 
-        attachImageViewScaleChangeListener();
-
         addEtTitleTouchListener();
     }
 
+    private void showImageWithLocalUri(Uri imageUri) {
+        if (imageUri != null) {
+            GenericDraweeHierarchy hierarchy = GenericDraweeHierarchyBuilder.newInstance(getResources())
+                .setActualImageScaleType(ScaleType.FIT_XY)
+                .build();
+            photoViewBackgroundImage.setHierarchy(hierarchy);
+            photoViewBackgroundImage
+                .setTapListener(new DoubleTapGestureListener(photoViewBackgroundImage));
+            DraweeController controller = Fresco.newDraweeControllerBuilder()
+                .setUri(Uri.fromFile(new File(imageUri.getPath())))
+                .build();
+            photoViewBackgroundImage.setTransformationListener(
+                () -> expandCollapseMediaDetail(false));
+            photoViewBackgroundImage.setController(controller);
+        }
+    }
+
     /**
      * Handles the drawable click listener for Edit Text
      */
@@ -200,17 +223,6 @@ private float convertDpToPixel(float dp, Context context) {
         return dp * ((float) context.getResources().getDisplayMetrics().densityDpi / DisplayMetrics.DENSITY_DEFAULT);
     }
 
-    /**
-     * Attaches the scale change listener to the image view
-     */
-    private void attachImageViewScaleChangeListener() {
-        photoViewBackgroundImage.setOnScaleChangeListener(
-                (scaleFactor, focusX, focusY) -> {
-                    //Whenever the uses plays with the image, lets collapse the media detail container
-                    expandCollapseLlMediaDetail(false);
-                });
-    }
-
     /**
      * attach the presenter with the view
      */
@@ -286,7 +298,7 @@ public void onImageProcessed(UploadItem uploadItem, Place place) {
         }
 
         descriptions = uploadItem.getDescriptions();
-        photoViewBackgroundImage.setImageURI(uploadItem.getMediaUri());
+        showImageWithLocalUri(uploadItem.getMediaUri());
         setDescriptionsInAdapter(descriptions);
     }
 
@@ -395,14 +407,17 @@ public void onDestroyView() {
 
     @OnClick(R.id.rl_container_title)
     public void onRlContainerTitleClicked() {
-        expandCollapseLlMediaDetail(!isExpanded);
+        expandCollapseMediaDetail(!isExpanded);
     }
 
     /**
      * show hide media detail based on
      * @param shouldExpand
      */
-    private void expandCollapseLlMediaDetail(boolean shouldExpand){
+    private void expandCollapseMediaDetail(boolean shouldExpand){
+        if (isExpanded == shouldExpand) {
+            return;
+        }
         llContainerMediaDetail.setVisibility(shouldExpand ? View.VISIBLE : View.GONE);
         isExpanded = !isExpanded;
         ibExpandCollapse.setRotation(ibExpandCollapse.getRotation() + 180);