Skip to content

Commit 2a6ad19

Browse files
Olegt0rrocelotl
authored and
Ashutosh Goel
committed
aiohttp instrumentation: correct url filter input type (open-telemetry#864)
* fix: correct _UrlFilterT * docs: CHANGELOG.md update * style: apply isort * fix: add yarl to docs requirements * Revert "fix: add yarl to docs requirements" This reverts commit e482ba5. * fix: add yarl to nitpick exceptions Co-authored-by: Diego Hurtado <[email protected]>
1 parent 7f03f93 commit 2a6ad19

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

CHANGELOG.md

+3-5
Original file line numberDiff line numberDiff line change
@@ -40,21 +40,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4040

4141
- `opentelemetry-instrumentation-django` Django: Conditionally create SERVER spans
4242
([#832](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/832))
43-
4443
- `opentelemetry-instrumentation-flask` Flask: Conditionally create SERVER spans
4544
([#828](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/828))
4645
- `opentelemetry-instrumentation-celery` Celery: Support partial task time limit
4746
([#846](https://github.com/open-telemetry/opentelemetry-python-contrib/issues/846))
48-
4947
- `opentelemetry-instrumentation-asgi` ASGI: Conditionally create SERVER spans
5048
([#843](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/843))
51-
5249
- `opentelemetry-instrumentation-django` Django: fix issue preventing detection of MIDDLEWARE_CLASSES
53-
5450
- `opentelemetry-instrumentation-sqlite3` Instrumentation now works with `dbapi2.connect`
55-
5651
- `opentelemetry-instrumentation-kafka` Kafka: safe kafka partition extraction
5752
([#872](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/872))
53+
- `opentelemetry-instrumentation-aiohttp-client` aiohttp: Correct url filter input type
54+
([#843](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/864))
55+
5856

5957
## [1.8.0-0.27b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.8.0-0.27b0) - 2021-12-17
6058

docs/nitpick-exceptions.ini

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ class_references=
2525
httpx.AsyncBaseTransport
2626
httpx.SyncByteStream
2727
httpx.AsyncByteStream
28+
yarl.URL
2829

2930
anys=
3031
; API

instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ def response_hook(span: Span, params: typing.Union[
9191

9292
import aiohttp
9393
import wrapt
94+
import yarl
9495

9596
from opentelemetry import context as context_api
9697
from opentelemetry import trace
@@ -108,7 +109,7 @@ def response_hook(span: Span, params: typing.Union[
108109
from opentelemetry.trace.status import Status, StatusCode
109110
from opentelemetry.util.http import remove_url_credentials
110111

111-
_UrlFilterT = typing.Optional[typing.Callable[[str], str]]
112+
_UrlFilterT = typing.Optional[typing.Callable[[yarl.URL], str]]
112113
_RequestHookT = typing.Optional[
113114
typing.Callable[[Span, aiohttp.TraceRequestStartParams], None]
114115
]

0 commit comments

Comments
 (0)