Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Commit 9bd67ed

Browse files
authored
fix typos in migration guide (#244)
1 parent 55e1b89 commit 9bd67ed

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

instrumentation-migration.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Migrate Instrumentation Library to contrib Repo
22

33
## Copy Other Instrumentation as Template
4-
Copy existing instrumentation from `plugins/node` directory (you can use `instrumentation-mongoose` as tamplate)
4+
Copy existing instrumentation from `plugins/node` directory (you can use `instrumentation-mongoose` as template)
55

6-
- update `package.json` to your instrumentation library (including `name`, `dependencies`, `sciprts`, `homepage`, `keywords` and anything else that might be related
6+
- update `package.json` to your instrumentation library (including `name`, `dependencies`, `scripts`, `homepage`, `keywords` and anything else that might be related
77

88
- update `README.md`. use the contrib template as it's different from `ext-js` template, and just update all the text and links according to your instrumentation.
99

@@ -18,7 +18,7 @@ Copy instrumentation files to `src` and `test` directories and apply changes to
1818

1919
You should apply the following changes to the files:
2020
- Don't use `moduleVersionAttributeName` from config. Store the value in an hook to make it accessible.
21-
- Use `fooInfo` for hooks configuration. e.g don't use many parameters to hook function signature, use just one paraameter and store everything inside.
21+
- Use `fooInfo` for hooks configuration. e.g don't use many parameters to hook function signature, use just one parameter and store everything inside.
2222
- Document any breaking changes in the README
2323
- use the new package name in instrumentation constructor
2424

0 commit comments

Comments
 (0)