Define retries at crank worker level

sebastienros · web-flow · commit c0498a068f17 · 2023-08-02T14:52:27.000-07:00
diff --git a/build/baselines-database-scenarios.yml b/build/baselines-database-scenarios.yml
@@ -72,7 +72,6 @@ steps:
     - task: PublishToAzureServiceBus@1
       condition: succeededOrFailed()
       timeoutInMinutes: 10
-      retryCountOnTaskFailure: 1
       displayName: "${{ s.displayName }} - ${{ b.displayName }}"
       inputs:
         connectedServiceName: ${{ parameters.connection }}
@@ -82,5 +81,6 @@ steps:
           {
             "name": "crank",
             "condition": "(${{ parameters.condition }})",
+            "retries": 1,
             "args": [ "${{ s.arguments }} ${{ b.arguments }} ${{ parameters.arguments }} $(azureProfile) --variable duration=30 --no-metadata --no-measurements --session $(session) --command-line-property --table BaselineBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
           }
diff --git a/build/baselines-scenarios.yml b/build/baselines-scenarios.yml
@@ -69,7 +69,6 @@ steps:
     - task: PublishToAzureServiceBus@1
       condition: succeededOrFailed()
       timeoutInMinutes: 10
-      retryCountOnTaskFailure: 1
       displayName: "${{ s.displayName }} - ${{ b.displayName }}"
       inputs:
         connectedServiceName: ${{ parameters.connection }}
@@ -79,5 +78,6 @@ steps:
           {
             "name": "crank",
             "condition": "(${{ parameters.condition }})",
+            "retries": 1,
             "args": [ "${{ s.arguments }} ${{ b.arguments }} ${{ parameters.arguments }} $(azureProfile) --no-metadata --no-measurements --session $(session) --command-line-property --table BaselineBenchmarks --sql SQL_CONNECTION_STRING  --chart" ]
           }
diff --git a/build/frameworks-database-scenarios.yml b/build/frameworks-database-scenarios.yml
@@ -50,7 +50,6 @@ steps:
   - task: PublishToAzureServiceBus@1
     condition: succeededOrFailed()
     displayName: ${{ s.displayName }}
-    retryCountOnTaskFailure: 1
     inputs:
       connectedServiceName: ${{ parameters.connection }}
       waitForCompletion: true
@@ -59,5 +58,6 @@ steps:
         {
           "name": "crank",
           "condition": "(${{ parameters.condition }})",
+          "retries": 1,
           "args": [ "${{ s.arguments }} ${{ parameters.arguments }} --application.noClean true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --chart" ] 
         }
diff --git a/build/frameworks-scenarios.yml b/build/frameworks-scenarios.yml
@@ -65,7 +65,6 @@ steps:
   - task: PublishToAzureServiceBus@1
     condition: succeededOrFailed()
     displayName: ${{ s.displayName }}
-    retryCountOnTaskFailure: 1
     inputs:
       connectedServiceName: ${{ parameters.connection }}
       waitForCompletion: true
@@ -74,5 +73,6 @@ steps:
         {
           "name": "crank",
           "condition": "(${{ parameters.condition }})",
+          "retries": 1,
           "args": [ "${{ s.arguments }} ${{ parameters.arguments }} --application.noClean true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --chart" ] 
         }
diff --git a/build/mono-database-scenarios.yml b/build/mono-database-scenarios.yml
@@ -39,7 +39,6 @@ steps:
       displayName: "${{ s.displayName }} - ${{ runtime.displayName }}"
       condition: succeededOrFailed()
       timeoutInMinutes: 60
-      retryCountOnTaskFailure: 1
       inputs:
         connectedServiceName: ${{ parameters.connection }}
         waitForCompletion: true
diff --git a/build/mono-scenarios.yml b/build/mono-scenarios.yml
@@ -47,7 +47,6 @@ steps:
       displayName: "${{ s.displayName }} - ${{ runtime.displayName }}"
       condition: succeededOrFailed()
       timeoutInMinutes: 60
-      retryCountOnTaskFailure: 1
       inputs:
         connectedServiceName: ${{ parameters.connection }}
         waitForCompletion: true
diff --git a/build/mvc-scenarios.yml b/build/mvc-scenarios.yml
@@ -87,7 +87,6 @@ steps:
     - task: PublishToAzureServiceBus@1
       condition: succeededOrFailed()
       displayName: ${{ s.displayName }}
-      retryCountOnTaskFailure: 1
       inputs:
         connectedServiceName: ${{ parameters.connection }}
         waitForCompletion: true
@@ -96,6 +95,7 @@ steps:
           {
             "name": "crank",
             "condition": "(${{ parameters.condition }})",
+            "retries": 1,
             "args": [ "${{ s.arguments }} $(azureProfile) ${{ parameters.arguments }} --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --application.framework net8.0 --application.options.collectCounters true --application.collectDependencies true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table MvcBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
           }
 
diff --git a/build/nativeaot-scenarios.yml b/build/nativeaot-scenarios.yml
@@ -135,7 +135,6 @@ steps:
   - task: PublishToAzureServiceBus@1
     displayName: "${{ s.displayName }}"
     condition: succeededOrFailed()
-    retryCountOnTaskFailure: 1
     inputs:
       connectedServiceName: ${{ parameters.connection }}
       waitForCompletion: true
@@ -144,5 +143,6 @@ steps:
         {
           "name": "crank",
           "condition": "(${{ parameters.condition }}) && (${{ s.condition }})",
+          "retries": 1,
           "args": [ "${{ s.arguments }} ${{ parameters.arguments }} --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --application.framework net8.0 --application.options.collectCounters true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table NativeAotBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
         }
diff --git a/build/signalr-scenarios.yml b/build/signalr-scenarios.yml
@@ -55,7 +55,6 @@ steps:
         condition: succeededOrFailed()
         enabled: ${{ not( and( eq(transport.displayName, 'ServerSentEvents'), eq(protocol.displayName, 'MessagePack'))) }}
         displayName: ${{ s.displayName }} ${{ transport.displayName }} ${{ protocol.displayName }}
-        retryCountOnTaskFailure: 1
         inputs:
           connectedServiceName: ${{ parameters.connection }}
           waitForCompletion: true
@@ -64,6 +63,7 @@ steps:
             {
               "timeout": "00:5:00",
               "condition": "${{ parameters.condition }}",
+              "retries": 1,
               "name": "crank",
               "args": [ "${{ s.arguments }} ${{ transport.arguments }} ${{ protocol.arguments }} --application.options.collectCounters true --load.options.collectCounters true ${{ parameters.arguments }} --load.channel edge --load.framework net8.0 --warmup.channel edge --warmup.framework net8.0 --application.framework net8.0 --session $(session) --command-line-property --table SignalRBenchmarks --sql SQL_CONNECTION_STRING --chart --no-measurements --no-metadata --warmup.options.discardResults true" ]
             }
diff --git a/build/trend-database-scenarios.yml b/build/trend-database-scenarios.yml
@@ -46,7 +46,6 @@ steps:
     displayName: "${{ s.displayName }}"
     condition: succeededOrFailed()
     timeoutInMinutes: 10
-    retryCountOnTaskFailure: 1
     inputs:
       connectedServiceName: ${{ parameters.connection }}
       waitForCompletion: true
@@ -55,5 +54,6 @@ steps:
         {
           "name": "crank",
           "condition": "(${{ parameters.condition }})",
+          "retries": 1,
           "args": [ "${{ s.arguments }} $(azureProfile) --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --application.framework net8.0 ${{ parameters.arguments }} --application.options.collectCounters true --application.collectDependencies true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
         }
diff --git a/build/trend-scenarios.yml b/build/trend-scenarios.yml
@@ -85,7 +85,6 @@ steps:
     displayName: "${{ s.displayName }}"
     condition: succeededOrFailed()
     timeoutInMinutes: 10
-    retryCountOnTaskFailure: 1
     inputs:
       connectedServiceName: ${{ parameters.connection }}
       waitForCompletion: true
@@ -94,5 +93,6 @@ steps:
         {
           "name": "crank",
           "condition": "(${{ parameters.condition }})",
+          "retries": 1,
           "args": [ "${{ s.arguments }} $(azureProfile) --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --application.framework net8.0 --application.collectDependencies true ${{ parameters.arguments }} --application.options.collectCounters true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
         }

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,6 @@ steps:`
`72`	`72`	`- task: PublishToAzureServiceBus@1`
`73`	`73`	`condition: succeededOrFailed()`
`74`	`74`	`timeoutInMinutes: 10`
`75`		`- retryCountOnTaskFailure: 1`
`76`	`75`	`displayName: "${{ s.displayName }} - ${{ b.displayName }}"`
`77`	`76`	`inputs:`
`78`	`77`	`connectedServiceName: ${{ parameters.connection }}`
`@@ -82,5 +81,6 @@ steps:`
`82`	`81`	`{`
`83`	`82`	`"name": "crank",`
`84`	`83`	`"condition": "(${{ parameters.condition }})",`
	`84`	`+ "retries": 1,`
`85`	`85`	`"args": [ "${{ s.arguments }} ${{ b.arguments }} ${{ parameters.arguments }} $(azureProfile) --variable duration=30 --no-metadata --no-measurements --session $(session) --command-line-property --table BaselineBenchmarks --sql SQL_CONNECTION_STRING --chart" ]`
`86`	`86`	`}`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ steps:`
`69`	`69`	`- task: PublishToAzureServiceBus@1`
`70`	`70`	`condition: succeededOrFailed()`
`71`	`71`	`timeoutInMinutes: 10`
`72`		`- retryCountOnTaskFailure: 1`
`73`	`72`	`displayName: "${{ s.displayName }} - ${{ b.displayName }}"`
`74`	`73`	`inputs:`
`75`	`74`	`connectedServiceName: ${{ parameters.connection }}`
`@@ -79,5 +78,6 @@ steps:`
`79`	`78`	`{`
`80`	`79`	`"name": "crank",`
`81`	`80`	`"condition": "(${{ parameters.condition }})",`
	`81`	`+ "retries": 1,`
`82`	`82`	`"args": [ "${{ s.arguments }} ${{ b.arguments }} ${{ parameters.arguments }} $(azureProfile) --no-metadata --no-measurements --session $(session) --command-line-property --table BaselineBenchmarks --sql SQL_CONNECTION_STRING --chart" ]`
`83`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,6 @@ steps:`
`50`	`50`	`- task: PublishToAzureServiceBus@1`
`51`	`51`	`condition: succeededOrFailed()`
`52`	`52`	`displayName: ${{ s.displayName }}`
`53`		`- retryCountOnTaskFailure: 1`
`54`	`53`	`inputs:`
`55`	`54`	`connectedServiceName: ${{ parameters.connection }}`
`56`	`55`	`waitForCompletion: true`
`@@ -59,5 +58,6 @@ steps:`
`59`	`58`	`{`
`60`	`59`	`"name": "crank",`
`61`	`60`	`"condition": "(${{ parameters.condition }})",`
	`61`	`+ "retries": 1,`
`62`	`62`	`"args": [ "${{ s.arguments }} ${{ parameters.arguments }} --application.noClean true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --chart" ]`
`63`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,6 @@ steps:`
`65`	`65`	`- task: PublishToAzureServiceBus@1`
`66`	`66`	`condition: succeededOrFailed()`
`67`	`67`	`displayName: ${{ s.displayName }}`
`68`		`- retryCountOnTaskFailure: 1`
`69`	`68`	`inputs:`
`70`	`69`	`connectedServiceName: ${{ parameters.connection }}`
`71`	`70`	`waitForCompletion: true`
`@@ -74,5 +73,6 @@ steps:`
`74`	`73`	`{`
`75`	`74`	`"name": "crank",`
`76`	`75`	`"condition": "(${{ parameters.condition }})",`
	`76`	`+ "retries": 1,`
`77`	`77`	`"args": [ "${{ s.arguments }} ${{ parameters.arguments }} --application.noClean true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --chart" ]`
`78`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,6 @@ steps:`
`87`	`87`	`- task: PublishToAzureServiceBus@1`
`88`	`88`	`condition: succeededOrFailed()`
`89`	`89`	`displayName: ${{ s.displayName }}`
`90`		`- retryCountOnTaskFailure: 1`
`91`	`90`	`inputs:`
`92`	`91`	`connectedServiceName: ${{ parameters.connection }}`
`93`	`92`	`waitForCompletion: true`
`@@ -96,6 +95,7 @@ steps:`
`96`	`95`	`{`
`97`	`96`	`"name": "crank",`
`98`	`97`	`"condition": "(${{ parameters.condition }})",`
	`98`	`+ "retries": 1,`
`99`	`99`	"args": [ "${{ s.arguments }} $(azureProfile) ${{ parameters.arguments }} --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --application.framework net8.0 --application.options.collectCounters true --application.collectDependencies true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table MvcBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
`100`	`100`	`}`
`101`	`101`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,6 @@ steps:`
`135`	`135`	`- task: PublishToAzureServiceBus@1`
`136`	`136`	`displayName: "${{ s.displayName }}"`
`137`	`137`	`condition: succeededOrFailed()`
`138`		`- retryCountOnTaskFailure: 1`
`139`	`138`	`inputs:`
`140`	`139`	`connectedServiceName: ${{ parameters.connection }}`
`141`	`140`	`waitForCompletion: true`
`@@ -144,5 +143,6 @@ steps:`
`144`	`143`	`{`
`145`	`144`	`"name": "crank",`
`146`	`145`	`"condition": "(${{ parameters.condition }}) && (${{ s.condition }})",`
	`146`	`+ "retries": 1,`
`147`	`147`	"args": [ "${{ s.arguments }} ${{ parameters.arguments }} --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --application.framework net8.0 --application.options.collectCounters true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table NativeAotBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
`148`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ steps:`
`46`	`46`	`displayName: "${{ s.displayName }}"`
`47`	`47`	`condition: succeededOrFailed()`
`48`	`48`	`timeoutInMinutes: 10`
`49`		`- retryCountOnTaskFailure: 1`
`50`	`49`	`inputs:`
`51`	`50`	`connectedServiceName: ${{ parameters.connection }}`
`52`	`51`	`waitForCompletion: true`
`@@ -55,5 +54,6 @@ steps:`
`55`	`54`	`{`
`56`	`55`	`"name": "crank",`
`57`	`56`	`"condition": "(${{ parameters.condition }})",`
	`57`	`+ "retries": 1,`
`58`	`58`	"args": [ "${{ s.arguments }} $(azureProfile) --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --application.framework net8.0 ${{ parameters.arguments }} --application.options.collectCounters true --application.collectDependencies true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,6 @@ steps:`
`85`	`85`	`displayName: "${{ s.displayName }}"`
`86`	`86`	`condition: succeededOrFailed()`
`87`	`87`	`timeoutInMinutes: 10`
`88`		`- retryCountOnTaskFailure: 1`
`89`	`88`	`inputs:`
`90`	`89`	`connectedServiceName: ${{ parameters.connection }}`
`91`	`90`	`waitForCompletion: true`
`@@ -94,5 +93,6 @@ steps:`
`94`	`93`	`{`
`95`	`94`	`"name": "crank",`
`96`	`95`	`"condition": "(${{ parameters.condition }})",`
	`96`	`+ "retries": 1,`
`97`	`97`	"args": [ "${{ s.arguments }} $(azureProfile) --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --application.framework net8.0 --application.collectDependencies true ${{ parameters.arguments }} --application.options.collectCounters true --no-metadata --no-measurements --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --chart" ]
`98`	`98`	`}`