Skip to content

Commit 3b72f74

Browse files
committed
upgraded passport to 0.6, fixed /logout route
1 parent 0b32b55 commit 3b72f74

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

Diff for: builderbook/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"next": "^12.1.6",
4444
"node-fetch": "^2.6.1",
4545
"nprogress": "^0.2.0",
46-
"passport": "^0.4.1",
46+
"passport": "^0.6.0",
4747
"passport-google-oauth": "^2.0.0",
4848
"prop-types": "^15.7.2",
4949
"qs": "^6.10.1",

Diff for: builderbook/server/google.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,13 @@ function setupGoogle({ server, ROOT_URL }) {
9292
},
9393
);
9494

95-
server.get('/logout', (req, res) => {
96-
req.logout();
97-
res.redirect('/login');
95+
server.get('/logout', (req, res, next) => {
96+
req.logout((err) => {
97+
if (err) {
98+
next(err);
99+
}
100+
res.redirect('/login');
101+
});
98102
});
99103
}
100104

Diff for: builderbook/yarn.lock

+7-6
Original file line numberDiff line numberDiff line change
@@ -5041,13 +5041,14 @@ [email protected]:
50415041
resolved "https://registry.yarnpkg.com/passport-strategy/-/passport-strategy-1.0.0.tgz#b5539aa8fc225a3d1ad179476ddf236b440f52e4"
50425042
integrity sha1-tVOaqPwiWj0a0XlHbd8ja0QPUuQ=
50435043

5044-
passport@^0.4.1:
5045-
version "0.4.1"
5046-
resolved "https://registry.yarnpkg.com/passport/-/passport-0.4.1.tgz#941446a21cb92fc688d97a0861c38ce9f738f270"
5047-
integrity sha512-IxXgZZs8d7uFSt3eqNjM9NQ3g3uQCW5avD8mRNoXV99Yig50vjuaez6dQK2qC0kVWPRTujxY0dWgGfT09adjYg==
5044+
passport@^0.6.0:
5045+
version "0.6.0"
5046+
resolved "https://registry.yarnpkg.com/passport/-/passport-0.6.0.tgz#e869579fab465b5c0b291e841e6cc95c005fac9d"
5047+
integrity sha512-0fe+p3ZnrWRW74fe8+SvCyf4a3Pb2/h7gFkQ8yTJpAO50gDzlfjZUZTO1k5Eg9kUct22OxHLqDZoKUWRHOh9ug==
50485048
dependencies:
50495049
passport-strategy "1.x.x"
50505050
pause "0.0.1"
5051+
utils-merge "^1.0.1"
50515052

50525053
path-exists@^3.0.0:
50535054
version "3.0.0"
@@ -5092,7 +5093,7 @@ path-type@^4.0.0:
50925093
50935094
version "0.0.1"
50945095
resolved "https://registry.yarnpkg.com/pause/-/pause-0.0.1.tgz#1d408b3fdb76923b9543d96fb4c9dfd535d9cb5d"
5095-
integrity sha1-HUCLP9t2kjuVQ9lvtMnf1TXZy10=
5096+
integrity sha512-KG8UEiEVkR3wGEb4m5yZkVCzigAD+cVEJck2CzYZO37ZGJfctvVptVO192MwrtPhzONn6go8ylnOdMhKqi4nfg==
50965097

50975098
picocolors@^1.0.0:
50985099
version "1.0.0"
@@ -6401,7 +6402,7 @@ util-deprecate@^1.0.1, util-deprecate@~1.0.1:
64016402
resolved "https://registry.yarnpkg.com/util-deprecate/-/util-deprecate-1.0.2.tgz#450d4dc9fa70de732762fbd2d4a28981419a0ccf"
64026403
integrity sha1-RQ1Nyfpw3nMnYvvS1KKJgUGaDM8=
64036404

6404-
6405+
64056406
version "1.0.1"
64066407
resolved "https://registry.yarnpkg.com/utils-merge/-/utils-merge-1.0.1.tgz#9f95710f50a267947b2ccc124741c1028427e713"
64076408
integrity sha1-n5VxD1CiZ5R7LMwSR0HBAoQn5xM=

0 commit comments

Comments
 (0)