Use simple spinlock in AtomicU64

Author: taiki-e

Diff for: src/sync/atomic.rs

@@ -11,33 +11,86 @@ mod imp {
 
 #[cfg(any(target_arch = "arm", target_arch = "mips", target_arch = "powerpc"))]
 mod imp {
-    use std::sync::atomic::Ordering;
-    use std::sync::Mutex;
+    use std::cell::UnsafeCell;
+    use std::ops::{Deref, DerefMut};
+    use std::sync::atomic::{AtomicBool, Ordering};
 
-    #[derive(Debug)]
-    pub(crate) struct AtomicU64(Mutex<u64>);
+    use crossbeam_utils::Backoff;
+
+    pub(crate) struct AtomicU64(Spinlock<u64>);
 
     impl AtomicU64 {
-        pub(crate) fn new(val: u64) -> Self {
-            Self(Mutex::new(val))
+        pub(crate) const fn new(val: u64) -> Self {
+            Self(Spinlock::new(val))
         }
 
         pub(crate) fn load(&self, _: Ordering) -> u64 {
-            *self.0.lock().unwrap()
+            *self.0.lock()
         }
 
         pub(crate) fn fetch_add(&self, val: u64, _: Ordering) -> u64 {
-            let mut lock = self.0.lock().unwrap();
+            let mut lock = self.0.lock();
             let prev = *lock;
             *lock = prev + val;
             prev
         }
 
         pub(crate) fn fetch_sub(&self, val: u64, _: Ordering) -> u64 {
-            let mut lock = self.0.lock().unwrap();
+            let mut lock = self.0.lock();
             let prev = *lock;
             *lock = prev - val;
             prev
         }
     }
+
+    /// A simple spinlock.
+    pub(crate) struct Spinlock<T> {
+        flag: AtomicBool,
+        value: UnsafeCell<T>,
+    }
+
+    unsafe impl<T: Send> Send for Spinlock<T> {}
+    unsafe impl<T: Send> Sync for Spinlock<T> {}
+
+    impl<T> Spinlock<T> {
+        /// Returns a new spinlock initialized with `value`.
+        pub(crate) const fn new(value: T) -> Self {
+            Self {
+                flag: AtomicBool::new(false),
+                value: UnsafeCell::new(value),
+            }
+        }
+
+        /// Locks the spinlock.
+        pub(crate) fn lock(&self) -> SpinlockGuard<'_, T> {
+            let backoff = Backoff::new();
+            while self.flag.swap(true, Ordering::Acquire) {
+                backoff.snooze();
+            }
+            SpinlockGuard(self)
+        }
+    }
+
+    /// A guard holding a spinlock locked.
+    pub(crate) struct SpinlockGuard<'a, T>(&'a Spinlock<T>);
+
+    impl<T> Drop for SpinlockGuard<'_, T> {
+        fn drop(&mut self) {
+            self.0.flag.store(false, Ordering::Release);
+        }
+    }
+
+    impl<T> Deref for SpinlockGuard<'_, T> {
+        type Target = T;
+
+        fn deref(&self) -> &T {
+            unsafe { &*self.0.value.get() }
+        }
+    }
+
+    impl<T> DerefMut for SpinlockGuard<'_, T> {
+        fn deref_mut(&mut self) -> &mut T {
+            unsafe { &mut *self.0.value.get() }
+        }
+    }
 }

Diff for: src/task/blocking.rs

@@ -13,11 +13,6 @@ use crate::utils::abort_on_panic;
 
 const MAX_THREADS: u64 = 10_000;
 
-#[cfg(any(target_arch = "arm", target_arch = "mips", target_arch = "powerpc"))]
-lazy_static! {
-    static ref DYNAMIC_THREAD_COUNT: AtomicU64 = AtomicU64::new(0);
-}
-#[cfg(not(any(target_arch = "arm", target_arch = "mips", target_arch = "powerpc")))]
 static DYNAMIC_THREAD_COUNT: AtomicU64 = AtomicU64::new(0);
 
 struct Pool {

Diff for: src/task/task.rs

@@ -113,11 +113,6 @@ pub struct TaskId(NonZeroU64);
 
 impl TaskId {
     pub(crate) fn new() -> TaskId {
-        #[cfg(any(target_arch = "arm", target_arch = "mips", target_arch = "powerpc"))]
-        lazy_static::lazy_static! {
-            static ref COUNTER: AtomicU64 = AtomicU64::new(1);
-        }
-        #[cfg(not(any(target_arch = "arm", target_arch = "mips", target_arch = "powerpc")))]
         static COUNTER: AtomicU64 = AtomicU64::new(1);
 
         let id = COUNTER.fetch_add(1, Ordering::Relaxed);