Skip to content

Commit dc7084f

Browse files
committed
rollback renaming for SchemaValidateResult
1 parent 903e8e7 commit dc7084f

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

src/schema-parser/asyncapi-schema-parser.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { SchemaParser, ParseSchemaInput, ValidateSchemaInput } from "../schema-parser";
22
import Ajv from "ajv";
33
import { JSONSchema7 } from "json-schema"
4-
import type { AsyncAPISchema, SchemaValidateError } from '../types';
4+
import type { AsyncAPISchema, SchemaValidateResult } from '../types';
55

66
const ajv = new Ajv({
77
allErrors: true,
@@ -15,9 +15,9 @@ export function AsyncAPISchemaParser(): SchemaParser {
1515
}
1616
}
1717

18-
async function validate(input: ValidateSchemaInput<unknown, unknown>): Promise<SchemaValidateError[]> {
18+
async function validate(input: ValidateSchemaInput<unknown, unknown>): Promise<SchemaValidateResult[]> {
1919
const schema = input.data as JSONSchema7;
20-
let errors: SchemaValidateError[] = [];
20+
let errors: SchemaValidateResult[] = [];
2121

2222
try {
2323
ajv.compile(schema);
@@ -33,8 +33,8 @@ async function validate(input: ValidateSchemaInput<unknown, unknown>): Promise<S
3333
return errors;
3434
}
3535

36-
function ajvToSpectralErrors(error: Error): SchemaValidateError[] {
37-
let errors: SchemaValidateError[] = [];
36+
function ajvToSpectralErrors(error: Error): SchemaValidateResult[] {
37+
let errors: SchemaValidateResult[] = [];
3838
let errorMessage = error.message;
3939

4040
// Validation errors.
@@ -51,7 +51,7 @@ function ajvToSpectralErrors(error: Error): SchemaValidateError[] {
5151
const path = message.slice(0, splitIndex);
5252
const error = message.slice(splitIndex + 1);
5353

54-
const resultErr: SchemaValidateError = {
54+
const resultErr: SchemaValidateResult = {
5555
message: error,
5656
path: path.split("/")
5757
};
@@ -60,7 +60,7 @@ function ajvToSpectralErrors(error: Error): SchemaValidateError[] {
6060
});
6161
} else {
6262
// Not a validation error
63-
const resultErr: SchemaValidateError = {
63+
const resultErr: SchemaValidateResult = {
6464
message: error.message,
6565
};
6666

src/schema-parser/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { Parser } from '../parser';
2-
import type { AsyncAPISchema, DetailedAsyncAPI, SchemaValidateError } from '../types';
2+
import type { AsyncAPISchema, DetailedAsyncAPI, SchemaValidateResult } from '../types';
33

44
export interface ValidateSchemaInput<D = unknown, M = unknown> {
55
readonly asyncapi: DetailedAsyncAPI;
@@ -20,7 +20,7 @@ export interface ParseSchemaInput<D = unknown, M = unknown> {
2020
}
2121

2222
export interface SchemaParser<D = unknown, M = unknown> {
23-
validate: (input: ValidateSchemaInput<D, M>) => void | SchemaValidateError[] | Promise<void | SchemaValidateError[]>;
23+
validate: (input: ValidateSchemaInput<D, M>) => void | SchemaValidateResult[] | Promise<void | SchemaValidateResult[]>;
2424
parse: (input: ParseSchemaInput<D, M>) => AsyncAPISchema | Promise<AsyncAPISchema>;
2525
getMimeTypes: () => Array<string>;
2626
}

src/types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ export interface DetailedAsyncAPI {
1717
}
1818

1919
export type Diagnostic = ISpectralDiagnostic;
20-
export type SchemaValidateError = IFunctionResult;
20+
export type SchemaValidateResult = IFunctionResult;
2121
export type AsyncAPISchema = JSONSchema7;

test/schema-parser/asyncapi-schema-parser.spec.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { ParseSchemaInput, ValidateSchemaInput } from '../../src/schema-parser/index';
22
import { AsyncAPISchemaParser } from '../../src/schema-parser/asyncapi-schema-parser';
3-
import { SchemaValidateError } from '../../src/types';
3+
import { SchemaValidateResult } from '../../src/types';
44

55
describe('AsyncAPISchemaParser', function () {
66

@@ -59,7 +59,7 @@ describe('AsyncAPISchemaParser', function () {
5959
};
6060

6161
const result = await parser.validate(schema);
62-
const expectedResult: SchemaValidateError[] = [
62+
const expectedResult: SchemaValidateResult[] = [
6363
{ "message": "must be object,boolean", "path": ["data", "properties", "name", "if"] },
6464
{ "message": "must be array", "path": ["data", "oneOf"] }
6565
];
@@ -80,7 +80,7 @@ describe('AsyncAPISchemaParser', function () {
8080
};
8181

8282
const result = await parser.validate(schema);
83-
const expectedResult: SchemaValidateError[] = [
83+
const expectedResult: SchemaValidateResult[] = [
8484
{ "message": "no schema with key or ref \"non-existent-meta-schema\"" },
8585
];
8686

0 commit comments

Comments
 (0)