Add worker thread hack

This adds a work-around to `rust#91979` (rust-lang/rust#91979)

A segmentation fault is currently triggered on worker thread exit if:

* Application runs with `atlaspack` on the main thread
* Plugin on worker-thread imports `parcel/rust`

The work-around is to force parcel native bindings to be loaded eagerly if
available.

Test Plan: test dev release

Pull Request: #472

Author: yamadapc

.changeset/tiny-knives-scream.md

@@ -0,0 +1,5 @@
+---
+'@atlaspack/core': patch
+---
+
+Fix segmentation fault on exit on certain cases

packages/core/core/src/Atlaspack.js

@@ -58,11 +58,16 @@ import {
   fromProjectPathRelative,
 } from './projectPath';
 import {tracer} from '@atlaspack/profiler';
-import {setFeatureFlags, DEFAULT_FEATURE_FLAGS} from '@atlaspack/feature-flags';
+import {
+  getFeatureFlag,
+  setFeatureFlags,
+  DEFAULT_FEATURE_FLAGS,
+} from '@atlaspack/feature-flags';
 import {AtlaspackV3, FileSystemV3} from './atlaspack-v3';
 import createAssetGraphRequestJS from './requests/AssetGraphRequest';
 import {createAssetGraphRequestRust} from './requests/AssetGraphRequestRust';
 import type {AssetGraphRequestResult} from './requests/AssetGraphRequest';
+import {loadRustWorkerThreadDylibHack} from './rustWorkerThreadDylibHack';
 
 registerCoreWithSerializer();
 
@@ -117,6 +122,10 @@ export default class Atlaspack {
     };
     setFeatureFlags(featureFlags);
 
+    if (getFeatureFlag('enableRustWorkerThreadDylibHack')) {
+      loadRustWorkerThreadDylibHack();
+    }
+
     await initSourcemaps;
     await initRust?.();
 

packages/core/core/src/rustWorkerThreadDylibHack.js

@@ -0,0 +1,18 @@
+// @flow strict-local
+
+/**
+ * This is a workaround for https://github.com/rust-lang/rust/issues/91979
+ * when running atlaspack with parcel bindings, it is possible that the parcel
+ * dylib will be loaded from a node worker thread, which causes a crash on exit.
+ *
+ * This is a workaround to ensure that the parcel dylib is loaded in the main
+ * thread, which fixes the crash.
+ */
+export function loadRustWorkerThreadDylibHack() {
+  try {
+    // $FlowFixMe
+    require('@parcel/rust'); // eslint-disable-line
+  } catch (err) {
+    /* ignore */
+  }
+}

packages/core/feature-flags/src/index.js

@@ -20,7 +20,8 @@ export const DEFAULT_FEATURE_FLAGS: FeatureFlags = {
   inlineBundlesSourceMapFixes: false,
   conditionalBundlingNestedRuntime: false,
   patchProjectPaths: false,
-  inlineStringReplacementPerf: false,
+  enableRustWorkerThreadDylibHack: false,
+  inlineStringReplacementPerf: true,
 };
 
 let featureFlagValues: FeatureFlags = {...DEFAULT_FEATURE_FLAGS};

packages/core/feature-flags/src/types.js

@@ -58,7 +58,10 @@ export type FeatureFlags = {|
    * This feature is experimental and should not be used in production. It will used to test downloadble cache artefacts.
    */
   patchProjectPaths: boolean,
-
+  /**
+   * Enable loading of the parcel dylib in the main thread.
+   */
+  enableRustWorkerThreadDylibHack: boolean,
   /**
    * Enables optimized inline string replacement perf for the packager.
    * Used heavily for inline bundles.