Coffeelint settings and fixes

Author: lierdakil

coffeelint.json

@@ -0,0 +1,42 @@
+{
+  "arrow_spacing": {
+    "name": "arrow_spacing",
+    "level": "error"
+  },
+  "ensure_comprehensions": {
+    "name": "ensure_comprehensions",
+    "level": "error"
+  },
+  "max_line_length": {
+    "name": "max_line_length",
+    "value": 120,
+    "level": "error",
+    "limitComments": true
+  },
+  "indentation": {
+    "name": "indentation",
+    "value": 2,
+    "level": "error"
+  },
+  "no_empty_param_list": {
+    "name": "no_empty_param_list",
+    "level": "error"
+  },
+  "cyclomatic_complexity": {
+    "name": "cyclomatic_complexity",
+    "value": 22,
+    "level": "error"
+  },
+  "no_unnecessary_fat_arrows": {
+    "name": "no_unnecessary_fat_arrows",
+    "level": "error"
+  },
+  "space_operators": {
+    "name": "space_operators",
+    "level": "error"
+  },
+  "spacing_after_comma": {
+    "name": "spacing_after_comma",
+    "level": "error"
+  }
+}

lib/editor-control.coffee

@@ -3,7 +3,7 @@ ImportListView = require './import-list-view'
 
 {bufferPositionFromMouseEvent} = require './utils'
 {TooltipMessage} = require './tooltip-view'
-{Range,CompositeDisposable,Disposable} = require 'atom'
+{Range, CompositeDisposable, Disposable} = require 'atom'
 
 class EditorControl
   constructor: (@editor, @manager) ->
@@ -31,12 +31,12 @@ class EditorControl
     # buffer events for automatic check
     buffer = @editor.getBuffer()
     editorElement = atom.views.getView(@editor)
-    @disposables.add buffer.onWillSave () ->
+    @disposables.add buffer.onWillSave ->
       # TODO if uri was changed, then we have to remove all current markers
       if atom.config.get('ide-haskell.onSavePrettify')
         atom.commands.dispatch editorElement, 'ide-haskell:prettify-file'
 
-    @disposables.add buffer.onDidSave () ->
+    @disposables.add buffer.onDidSave ->
       # TODO if uri was changed, then we have to remove all current markers
       if atom.config.get('ide-haskell.onSaveCheck')
         atom.commands.dispatch editorElement, 'ide-haskell:check-file'
@@ -56,7 +56,7 @@ class EditorControl
       @clearExprTypeTimeout()
       @exprTypeTimeout = setTimeout (=>
         (@showCheckResult e) or
-          (@showExpressionType bufferPt, 'mouse', 'get'+action)
+          (@showExpressionType bufferPt, 'mouse', 'get' + action)
       ), atom.config.get('ide-haskell.expressionTypeInterval')
     @disposables.add @editorElement, 'mouseout', '.scroll-view', (e) =>
       action = atom.config.get('ide-haskell.onMouseHoverShow')
@@ -82,7 +82,7 @@ class EditorControl
     @editorElement = null
     @editor = null
     @lastMouseBufferPt = null
-    @tooltipMarkers=null
+    @tooltipMarkers = null
 
   # helper function to hide tooltip and stop timeout
   clearExprTypeTimeout: ->
@@ -107,7 +107,7 @@ class EditorControl
     return unless uri is @editor.getURI()
 
     # create a new marker
-    range = new Range position, {row: position.row, column: position.column+1}
+    range = new Range position, {row: position.row, column: position.column + 1}
     marker = @editor.markBufferRange range,
       type: 'check-result'
       severity: severity
@@ -119,7 +119,7 @@ class EditorControl
         @decorateMarker(m)
 
   decorateMarker: (m) ->
-    cls = 'ide-haskell-'+m.getProperties().severity
+    cls = 'ide-haskell-' + m.getProperties().severity
     @gutter.decorateMarker m, type: 'line-number', class: cls
     @editor.decorateMarker m, type: 'highlight', class: cls
     @editor.decorateMarker m, type: 'line', class: cls
@@ -153,10 +153,10 @@ class EditorControl
       @hideExpressionType()
       return
 
-    runPendingEvent = ({fun,crange}) =>
+    runPendingEvent = ({fun, crange}) =>
       @showExpressionTypePendingEvent = null
       @showExpressionTypeRunning = true
-      @manager.backend?[fun] @editor.getBuffer(), crange, ({range,type,info}) =>
+      @manager.backend?[fun] @editor.getBuffer(), crange, ({range, type, info}) =>
         return unless @editor?
         if @showExpressionTypePendingEvent?
           runPendingEvent @showExpressionTypePendingEvent
@@ -177,7 +177,7 @@ class EditorControl
         unless type?
           @manager.backendWarning()
           return
-        @markerBufferRange=range
+        @markerBufferRange = range
         if mouseEvent or contextEvent
           tooltipMarker = @editor.markBufferPosition range.start
         else
@@ -200,7 +200,7 @@ class EditorControl
       runPendingEvent @showExpressionTypePendingEvent
 
   hideExpressionType: ->
-    @tooltipHighlightRange=null
+    @tooltipHighlightRange = null
     @tooltipMarkers.dispose()
     @tooltipMarkers = new CompositeDisposable
 
@@ -241,15 +241,15 @@ class EditorControl
         crange = @editor.getLastSelection().getBufferRange()
       else
         throw new Error "unknown event type #{eventType}"
-    @manager.backend.getType @editor.getBuffer(), crange, ({range,type}) =>
+    @manager.backend.getType @editor.getBuffer(), crange, ({range, type}) =>
       return unless @editor?
       n = @editor.indentationForBufferRow(range.start.row)
-      indent = ' '.repeat n*@editor.getTabLength()
-      @editor.scanInBufferRange /[\w'.]+/, range, ({matchText,stop}) =>
+      indent = ' '.repeat n * @editor.getTabLength()
+      @editor.scanInBufferRange /[\w'.]+/, range, ({matchText, stop}) =>
         symbol = matchText
-        pos=[range.start.row,0]
-        @editor.setTextInBufferRange [pos,pos],
-          indent+symbol+" :: "+type+"\n"
+        pos = [range.start.row, 0]
+        @editor.setTextInBufferRange [pos, pos],
+          indent + symbol + " :: " + type + "\n"
         stop()
 
   insertImport: (eventType) ->
@@ -271,12 +271,12 @@ class EditorControl
             #           "(\\s+as\\s+[\\w.']+)?(\\s+hiding)?"+
             #           "(\\s+\\((.*)\\))")
             buffer = @editor.getBuffer()
-            buffer.backwardsScan /^(\s*)import/, ({match,range}) =>
+            buffer.backwardsScan /^(\s*)import/, ({match, range}) =>
               r = buffer.rangeForRow range.start.row
-              @editor.setTextInBufferRange [r.end,r.end],
+              @editor.setTextInBufferRange [r.end, r.end],
                 "\n#{match[1]}import #{mod}"
 
-  closeTooltips: () ->
+  closeTooltips: ->
     @hideExpressionType()
     @hideCheckResult()
 

lib/ide-haskell.coffee

@@ -1,5 +1,5 @@
 {PluginManager} = require './plugin-manager'
-{TooltipMessage,TooltipElement} = require './tooltip-view'
+{TooltipMessage, TooltipElement} = require './tooltip-view'
 {getCabalProjectDir} = require './utils'
 {CompositeDisposable} = require 'atom'
 BackendHelper = require 'atom-backend-helper'
@@ -117,8 +117,8 @@ module.exports = IdeHaskell =
         atom.menu.update()
 
   setKB: (source, kbs) ->
-    for o,c of kbs
-      @watchKB o,source,c
+    for o, c of kbs
+      @watchKB o, source, c
 
   setHotkeys: ->
     @setKB 'atom-workspace',
@@ -135,7 +135,7 @@ module.exports = IdeHaskell =
       CloseTooltip: 'ide-haskell:close-tooltip'
 
   unsetHotkeys: ->
-    d.dispose() for o,d of @hotkeys
+    d.dispose() for o, d of @hotkeys
 
   isActive: ->
     !!@pluginManager
@@ -174,7 +174,7 @@ module.exports = IdeHaskell =
     # if we did not activate (no cabal project),
     # set up an event to activate when a haskell file is opened
     if not @isActive()
-      @disposables.add myself=atom.workspace.onDidOpen (event) =>
+      @disposables.add myself = atom.workspace.onDidOpen (event) =>
         if not @isActive()
           item = event.item
           if item?.getGrammar?()?.scopeName == "source.haskell"
@@ -217,16 +217,16 @@ module.exports = IdeHaskell =
           @pluginManager.lintFile target.getModel()
         'ide-haskell:prettify-file': ({target}) =>
           @pluginManager.prettifyFile target.getModel()
-        'ide-haskell:show-type': ({target,detail}) =>
+        'ide-haskell:show-type': ({target, detail}) =>
           @pluginManager.controller(target.getModel()).showExpressionType null,
-            getEventType(detail),'getType'
-        'ide-haskell:show-info': ({target,detail}) =>
+            getEventType(detail), 'getType'
+        'ide-haskell:show-info': ({target, detail}) =>
           @pluginManager.controller(target.getModel()).showExpressionType null,
-            getEventType(detail),'getInfo'
-        'ide-haskell:insert-type': ({target,detail}) =>
+            getEventType(detail), 'getInfo'
+        'ide-haskell:insert-type': ({target, detail}) =>
           @pluginManager.controller(target.getModel())
             .insertType getEventType(detail)
-        'ide-haskell:insert-import': ({target,detail}) =>
+        'ide-haskell:insert-import': ({target, detail}) =>
           @pluginManager.controller(target.getModel())
             .insertImport getEventType(detail)
         'ide-haskell:close-tooltip': ({target}) =>
@@ -294,7 +294,7 @@ module.exports = IdeHaskell =
 
   clearMenu: ->
     @menu.dispose()
-    @menu=null
+    @menu = null
     atom.menu.update()
 
   consumeBackend_0_1_2: (service) ->

lib/import-list-view.coffee

@@ -3,7 +3,7 @@
 
 module.exports=
 class ImportListView extends SelectListView
-  initialize: ({@onConfirmed,items}) ->
+  initialize: ({@onConfirmed, items}) ->
     super
     @panel = atom.workspace.addModalPanel
       item: this

lib/plugin-manager.coffee

@@ -12,7 +12,7 @@ class PluginManager
     @disposables = new CompositeDisposable
     @controllers = new WeakMap
 
-    @disposables.add @emitter=new Emitter
+    @disposables.add @emitter = new Emitter
 
     @createOutputViewPanel(state)
     @subscribeEditorController()
@@ -45,23 +45,23 @@ class PluginManager
     @outputView?.toggle()
 
   checkFile: (editor) ->
-    @checkOrLint editor,@backend?.checkBuffer,['error', 'warning']
+    @checkOrLint editor, @backend?.checkBuffer, ['error', 'warning']
 
   lintFile: (editor) ->
-    @checkOrLint editor,@backend?.lintBuffer,['lint']
+    @checkOrLint editor, @backend?.lintBuffer, ['lint']
 
   checkOrLint: (editor, func, types) =>
     return unless func?
     @outputView?.pendingCheck()
     func editor.getBuffer(), (res) =>
-      @checkResults[t] = (res.filter ({severity}) -> severity==t) for t in types
+      @checkResults[t] = (res.filter ({severity}) -> severity == t) for t in types
       @emitter.emit 'results-updated', {res: @checkResults, types}
 
   onResultsUpdated: (callback) =>
     @emitter.on 'results-updated', callback
 
   # File prettify
-  prettifyFile: (editor, format='haskell') ->
+  prettifyFile: (editor, format = 'haskell') ->
     [firstCursor, cursors...] = editor.getCursors().map (cursor) ->
       cursor.getBufferPosition()
     util = switch format
@@ -98,7 +98,7 @@ class PluginManager
   addController: (editor) ->
     unless @controllers.get(editor)?
       @controllers.set(editor, new EditorControl(editor, this))
-      @disposables.add editor.onDidDestroy () =>
+      @disposables.add editor.onDidDestroy =>
         @controllers.delete(editor) #deactivation is handled in EditorControl
 
   removeController: (editor) ->

lib/tooltip-view.coffee

@@ -5,13 +5,13 @@ class TooltipMessage
 
 class TooltipView extends HTMLElement
   setMessage: (message) ->
-    @inner.textContent=message.text
-    $(this).fadeTo(0,1)
+    @inner.textContent = message.text
+    $(this).fadeTo(0, 1)
     this
 
   createdCallback: ->
-    @rootElement=this
-    @inner=document.createElement('div')
+    @rootElement = this
+    @inner = document.createElement 'div'
     @appendChild @inner
 
   destroy: ->

lib/util-cabal-format.coffee

@@ -3,26 +3,26 @@ path = require 'path'
 Temp = require 'temp'
 FS = require 'fs'
 
-withTempFile = (contents,callback) ->
+withTempFile = (contents, callback) ->
   Temp.open
     prefix:'haskell-ghc-mod',
     suffix:'.hs',
-    (err,info) ->
+    (err, info) ->
       if err
         console.log(err)
         return
-      FS.writeSync info.fd,contents
+      FS.writeSync info.fd, contents
       callback info.path, ->
         FS.close info.fd, -> FS.unlink info.path
 
 # run cabal format
 prettify = (text, {onComplete, onFailure}) ->
   shpath = atom.config.get('ide-haskell.cabalPath')
 
-  withTempFile text, (path,close) ->
+  withTempFile text, (path, close) ->
     proc = new BufferedProcess
       command: shpath
-      args: ['format',path]
+      args: ['format', path]
       exit: ->
         FS.readFile path, encoding: 'utf-8', (error, text) ->
           if error?

lib/util-stylish-haskell.coffee

@@ -5,7 +5,7 @@ path = require 'path'
 # run stylish-haskell backend
 prettify = (text, {onComplete, onFailure}) ->
 
-  lines=[]
+  lines = []
 
   shpath = atom.config.get('ide-haskell.stylishHaskellPath')