fix: Optimizations #39
Conversation
aminya
force-pushed
the
optimizations
branch
2 times, most recently
from
b78571f to
c9d75fb
Compare
|
This is ready for now. I added a big file for testing. Currently, adding/removing decorations is pretty fast. We can do more optimization later if needed. |
|
@UziTech Could you invite me to the organization? Although I have full access to minimap repo, I am not a member! |
|
I don't have access to the organization. I just have access to each repo. I think if we are both going to be updating these repos we need to make sure each PR has at least one approval from a person that did not create the PR. |
This reverts commit b74c205.
|
OK. No problem. I was just confused about why I am not shown in the member list of the organization. |
package.json
Outdated
| @@ -38,6 +38,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@semantic-release/apm-config": "^8.0.0", | |||
| "@types/atom": "^1.40.5", | |||
There was a problem hiding this comment.
this package isn't written in typescript is this necessary?
There was a problem hiding this comment.
Datatips in JavaScript come from TypeScript. JavaScript itself is not smart enough to know what is going on in the code.
Here, I was checking some of the API of Atom to see where decorate API comes from.
There was a problem hiding this comment.
Can we remove it? I don't see how it helps.
There was a problem hiding this comment.
It helps the datatips. I reverted it anyway.
This reverts commit 27a6e72.
|
If you want to we could convert these packages to typescript. |
|
🎉 This PR is included in version 5.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Optimizes minimap-find-and-replace:
This is ready for now. I added a big file for testing. Currently, adding/removing decorations is pretty fast. We can do more optimization later if needed.