-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Build pipeline #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ok with that. Do you mean to keep both or to remove the jshint?
Ok. Do you mean to modify the current About the order, probably it is better to set the lint as first step because it is faster to get a failure and avoid waiting for tests to pass to then get an error from the linter. |
I fully endorse #490 as a way to solve this, i will add another PR to make sure the build breaks when the code-coverage is below a certain threshold. That would change the order (indeed) to lint - test (with blocking coverage-check) - nsp |
I am considering this one finished, thanks @MitMaro and @ziluvatar :-) |
I have already
I'd like to add two more things to make working on this repository a little bit easier
Would this be a good idea to do?
The text was updated successfully, but these errors were encountered: