Analyzer changes.

In some cases, this was "change a private method to return the concrete
type instead of an interface." This seemed reasonable and not breaking.

Author: tillig

src/Autofac/Builder/MetadataConfiguration.cs

@@ -16,7 +16,7 @@ namespace Autofac.Builder;
 /// <remarks>This feature was suggested by OJ Reeves (@TheColonial).</remarks>
 public class MetadataConfiguration<TMetadata>
 {
-    private readonly IDictionary<string, object?> _properties = new Dictionary<string, object?>();
+    private readonly Dictionary<string, object?> _properties = new Dictionary<string, object?>();
 
     /// <summary>
     /// Gets the set of properties that have been provided.

src/Autofac/ContainerBuilder.cs

@@ -39,7 +39,7 @@ public sealed class ContainerBuilder
     private static int _builderAlreadyAllocated;
 
     private readonly bool _clearRegistrationCaches;
-    private readonly IList<DeferredCallback> _configurationCallbacks = new List<DeferredCallback>();
+    private readonly List<DeferredCallback> _configurationCallbacks = new List<DeferredCallback>();
     private BuildCallbackService? _buildCallbacks;
     private bool _wasBuilt;
 
@@ -150,7 +150,7 @@ public ContainerBuilder RegisterBuildCallback(Action<ILifetimeScope> buildCallba
     /// <summary>
     /// Create a new container with the component registrations that have been made.
     /// </summary>
-    /// <param name="options">Options that influence the way the container is initialised.</param>
+    /// <param name="options">Options that influence the way the container is initialized.</param>
     /// <remarks>
     /// Build can only be called once per <see cref="ContainerBuilder"/>
     /// - this prevents ownership issues for provided instances.

src/Autofac/Core/DependencyResolutionException.cs

@@ -17,8 +17,8 @@ public class DependencyResolutionException : Exception
     /// <summary>
     /// Initializes a new instance of the <see cref="DependencyResolutionException"/> class.
     /// </summary>
-    /// <param name="info">The serialisation info.</param>
-    /// <param name="context">The serialisation streaming context.</param>
+    /// <param name="info">The serialization info.</param>
+    /// <param name="context">The serialization streaming context.</param>
     protected DependencyResolutionException(SerializationInfo info, StreamingContext context)
         : base(info, context)
     {

src/Autofac/Core/Lifetime/LifetimeScope.cs

@@ -24,7 +24,7 @@ namespace Autofac.Core.Lifetime;
 public class LifetimeScope : Disposable, ISharingLifetimeScope, IServiceProvider
 {
     /// <summary>
-    /// Protects shared instances from concurrent access. Other members and the base class are threadsafe.
+    /// Protects shared instances from concurrent access. Other members and the base class are thread-safe.
     /// </summary>
     private readonly object _synchRoot = new();
     private readonly ConcurrentDictionary<Guid, object> _sharedInstances = new();
@@ -235,7 +235,7 @@ public ILifetimeScope BeginLoadContextLifetimeScope(object tag, AssemblyLoadCont
     }
 #endif
 
-    private ILifetimeScope InternalBeginLifetimeScope(object tag, Action<ContainerBuilder> configurationAction, bool isolatedScope)
+    private LifetimeScope InternalBeginLifetimeScope(object tag, Action<ContainerBuilder> configurationAction, bool isolatedScope)
     {
         if (configurationAction == null)
         {
@@ -278,7 +278,7 @@ private ILifetimeScope InternalBeginLifetimeScope(object tag, Action<ContainerBu
     /// <remarks>It is the responsibility of the caller to make sure that the registry is properly
     /// disposed of. This is generally done by adding the registry to the <see cref="Disposer"/>
     /// property of the child scope.</remarks>
-    private IComponentRegistryBuilder CreateScopeRestrictedRegistry(object tag, Action<ContainerBuilder> configurationAction, bool isolatedScope)
+    private ComponentRegistryBuilder CreateScopeRestrictedRegistry(object tag, Action<ContainerBuilder> configurationAction, bool isolatedScope)
     {
         var restrictedRootScopeLifetime = new MatchingScopeLifetime(tag);
         var tracker = new ScopeRestrictedRegisteredServicesTracker(restrictedRootScopeLifetime);

src/Autofac/Core/Resolving/Pipeline/ResolvePipelineBuilder.cs

@@ -233,7 +233,7 @@ public IResolvePipeline Build()
         return BuildPipeline(_last);
     }
 
-    private static IResolvePipeline BuildPipeline(MiddlewareDeclaration? lastDecl)
+    private static ResolvePipeline BuildPipeline(MiddlewareDeclaration? lastDecl)
     {
         // When we build, we go through the set and construct a single call stack, starting from the end.
         var current = lastDecl;

src/Autofac/Features/AttributeFilters/MetadataFilterAttribute.cs

@@ -190,7 +190,7 @@ private static Type GetElementType(Type type)
             .FirstOrDefault();
     }
 
-    private static IEnumerable<T> FilterAll<T>(IComponentContext context, string metadataKey, object metadataValue)
+    private static T[] FilterAll<T>(IComponentContext context, string metadataKey, object metadataValue)
     {
         // Using Lazy<T> to ensure components that aren't actually used won't get activated.
         return context.Resolve<IEnumerable<Meta<Lazy<T>>>>()

src/Autofac/Features/LightweightAdapters/LightweightAdapterRegistrationExtensions.cs

@@ -63,7 +63,7 @@ private static Service ServiceWithKey<TService>(object? key)
         return new KeyedService(key, typeof(TService));
     }
 
-    private static IRegistrationBuilder<TTo, LightweightAdapterActivatorData, DynamicRegistrationStyle>
+    private static RegistrationBuilder<TTo, LightweightAdapterActivatorData, DynamicRegistrationStyle>
         RegisterAdapter<TFrom, TTo>(
             ContainerBuilder builder,
             Func<IComponentContext, IEnumerable<Parameter>, TFrom, TTo> adapter,

src/Autofac/Util/Enforce.cs

@@ -14,7 +14,7 @@ internal static class Enforce
     /// <summary>
     /// Enforce that sequence does not contain null. Returns the
     /// value if valid so that it can be used inline in
-    /// base initialiser syntax.
+    /// base initializer syntax.
     /// </summary>
     /// <param name="value">The value.</param>
     /// <param name="name">The parameter name.</param>
@@ -55,7 +55,7 @@ public static T NotNull<T>([ValidatedNotNull] T value)
     /// <summary>
     /// Enforce that an argument is not null or empty. Returns the
     /// value if valid so that it can be used inline in
-    /// base initialiser syntax.
+    /// base initializer syntax.
     /// </summary>
     /// <param name="value">The value.</param>
     /// <param name="description">The description.</param>